Use spf13/cobra for docker push and docker pull#23256
Conversation
vdemeester
force-pushed
the
migrate-pull-push-to-cobra
branch
2 times, most recently
from
0489b1a to
58e4252
Compare
There was a problem hiding this comment.
This method (and the similar ImagePushPrivileged() are only used by one function trustedPush/pull , which is also used in only a single file (this one).
What do you think about either moving trustedPush/Pull into the new api/client/image package (which would require making the target struct exported), or alternatively moving ImagePullPrivileged to api/client/trust.go so we can remove this old module.
There was a problem hiding this comment.
@dnephin yeah I was wondering about that, same goes for push.go. I think I'll move it to api/client/trust.go for now 😇
vdemeester
force-pushed
the
migrate-pull-push-to-cobra
branch
2 times, most recently
from
803f35c to
01a6ded
Compare
There was a problem hiding this comment.
unnecessary blank line? 😄
vdemeester
force-pushed
the
migrate-pull-push-to-cobra
branch
7 times, most recently
from
ee0b4ce to
1825d81
Compare
There was a problem hiding this comment.
Oh damn, I messed up on a rebase 😓
vdemeester
force-pushed
the
migrate-pull-push-to-cobra
branch
from
1825d81 to
ef9c34a
Compare
|
LGTM |
|
LGTM and needs rebase |
vdemeester
force-pushed
the
migrate-pull-push-to-cobra
branch
from
ef9c34a to
de4e195
Compare
Signed-off-by: Vincent Demeester <[email protected]>
Signed-off-by: Vincent Demeester <[email protected]>
Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
migrate-pull-push-to-cobra
branch
from
de4e195 to
ad4e20c
Compare
|
LGTM |
Use spf13/cobra for docker push and docker pull
9 participants
Moves image command pull and push to
api/client/image/pull.goandapi/client/image/push.goand use cobra 🐍./cc @dnephin @thaJeztah @LK4D4 @cpuguy83
🐸
Signed-off-by: Vincent Demeester [email protected]