Skip to content

Use spf13/cobra for docker rmi#23242

Merged
LK4D4 merged 1 commit intomoby:masterfrom
vdemeester:migrate-rmi-to-cobra
Jun 5, 2016
Merged

Use spf13/cobra for docker rmi#23242
LK4D4 merged 1 commit intomoby:masterfrom
vdemeester:migrate-rmi-to-cobra

Conversation

@vdemeester
Copy link
Copy Markdown
Member

Moves image command rmi to api/client/image/remove.go and use cobra 🐍.

/cc @dnephin @thaJeztah @LK4D4

🐸

Signed-off-by: Vincent Demeester [email protected]

@dnephin
Copy link
Copy Markdown
Member

dnephin commented Jun 3, 2016

LGTM

1 similar comment
@cpuguy83
Copy link
Copy Markdown
Member

cpuguy83 commented Jun 3, 2016

LGTM

@cpuguy83
Copy link
Copy Markdown
Member

cpuguy83 commented Jun 4, 2016

This needs a rebase

@vdemeester vdemeester force-pushed the migrate-rmi-to-cobra branch from b4f3660 to 20881a8 Compare June 4, 2016 10:35
@vdemeester
Copy link
Copy Markdown
Member Author

Rebased 👼

@vdemeester vdemeester force-pushed the migrate-rmi-to-cobra branch from 20881a8 to 19bea96 Compare June 4, 2016 17:06
@vdemeester
Copy link
Copy Markdown
Member Author

Ah userns is green, just didn't tell GitHub about it 😓

Moves image command rmi to `api/client/image/remove.go` and use cobra :)

Signed-off-by: Vincent Demeester <[email protected]>
@vdemeester vdemeester force-pushed the migrate-rmi-to-cobra branch from 19bea96 to 60e48bd Compare June 5, 2016 20:40
@LK4D4
Copy link
Copy Markdown
Contributor

LK4D4 commented Jun 5, 2016

LGTM

@LK4D4 LK4D4 merged commit e94be2f into moby:master Jun 5, 2016
@vdemeester vdemeester deleted the migrate-rmi-to-cobra branch June 6, 2016 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants