Use spf13/cobra for docker search#23241
Merged
cpuguy83 merged 1 commit intomoby:masterfrom Jun 4, 2016
Merged
Conversation
vdemeester
added
area/cli
43 tasks
Member
Author
|
@dnelphin there is one weird thing though, putting λ ./bundles/latest/dynbinary-client/docker help
# […]
save Save one or more images to a tar archive
search [OPSearch the Docker Hub for images
start Start one or more stopped containers
# […]but the deprecated feature, I ❤️ it : λ ./bundles/latest/dynbinary-client/docker search --automated docker
Flag --automated has been deprecated, Use --filter=automated=true instead
NAME DESCRIPTION STARS OFFICIAL AUTOMATED
konradkleine/docker-registry-frontend Browse and modify your Docker registry in ... 95 [OK]
jdubois/jhipster-docker DO NOT USE: Former official JHipster Docke... 57 [OK]
martin/docker-cleanup-volumes Delete orphaned docker volumes 47 [OK]
datadog/docker-dd-agent Docker container for the Datadog Agent. 28 [OK] |
vdemeester
force-pushed
the
migrate-search-to-cobra
branch
from
64edb32 to
756a8ad
Compare
Member
|
@vdemeester I fixed that here: https://github.com/docker/docker/pull/23159/files#diff-4a2b6f090171fe18f7406cb69fb2e479R54 so it should be fine once that PR is merged. Doing the rebase now. |
vdemeester
force-pushed
the
migrate-search-to-cobra
branch
from
756a8ad to
193e3c4
Compare
Member
Author
|
@dnelphin perfect ! 👍 |
vdemeester
force-pushed
the
migrate-search-to-cobra
branch
from
193e3c4 to
d3b7b19
Compare
- Move image command search to `api/client/image/search.go` - Use cobra :) Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
migrate-search-to-cobra
branch
from
d3b7b19 to
a11ef10
Compare
Member
|
LGTM |
| return nil | ||
| } | ||
| return fmt.Errorf( | ||
| "\"%s\" requires exactly %d argument(s).\n\nUsage: %s\n\n%s", |
Member
There was a problem hiding this comment.
nit: this is different from what we have now; would be nice if we have a generic function to use singular/plural here
docker: "search" requires 1 argument.
Member
|
Funny; it treats LGTM (unless you want to update that nit 😄) |
Member
|
LGTM, windows error is know, gcc finished but didn't notify. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
api/client/image/search.go/cc @dnephin @thaJeztah @LK4D4
🐸
Signed-off-by: Vincent Demeester [email protected]