Carry #22228 : Rename graph drivers to storage drivers #23237
Conversation
vdemeester
force-pushed
the
carry-pr-22228
branch
from
6326c0f to
888ebf6
Compare
|
Already LGTM from @tiborvass (see original PR) |
Makefile
Outdated
There was a problem hiding this comment.
er "graphdriver" also in this sentence
|
Looks like we're running into the same failure again on WindowsTP5, so wondering if there is a relation to this change; @jhowardmsft any ideas? I already started looking into vendored code, e.g. https://github.com/docker/docker/blob/3d13fddd2bc4d679f0eaa68b0be877e5a816ad53/vendor/src/github.com/Microsoft/hcsshim/layerutils.go#L14-L23, but couldn't find anything really |
icecrime
added
the
status/failing-ci
vdemeester
force-pushed
the
carry-pr-22228
branch
from
888ebf6 to
b6918ed
Compare
daemon/storage/windows/windows.go
Outdated
There was a problem hiding this comment.
Looking to see anything obvious causing TP5 to fail. This isn't it (I don't think), but why aliased?
There was a problem hiding this comment.
hum, it shouldn't matter, the package name is winio anyway (https://github.com/Microsoft/go-winio/blob/master/file.go, …)
|
@thaJeztah The only thing I can spot is the go-winio aliasing. Everything appears fine. |
|
@jhowardmsft thanks for looking. I was wondering if somehow, somewhere something relied on a name. Just weird. Let me just try to run it again, maybe we've just been very unlucky |
|
Hum |
|
Went back to look at this failure after redeploying a bunch of TP5 nodes this evening. Unfortunately it now needs a rebase 😢 |
This is already the case in most of the CLI. This PR updates the codebase to be more consistent. This should not change anything for the user. Signed-off-by: Thomas Gazagnaire <[email protected]>
This is already the case in most of the CLI. This PR updates the codebase to be more consistent. This should not change anything for the user. Signed-off-by: Thomas Gazagnaire <[email protected]>
Signed-off-by: Thomas Gazagnaire <[email protected]>
Signed-off-by: Thomas Gazagnaire <[email protected]>
Signed-off-by: Thomas Gazagnaire <[email protected]>
This is to keep consistent with the name that we are using in the documentation, where "storage drivers" is prefered over the now deprecated "graph drivers" terminology. Signed-off-by: Thomas Gazagnaire <[email protected]>
Signed-off-by: Thomas Gazagnaire <[email protected]>
This match with what the documentation for `--graph` says. Signed-off-by: Thomas Gazagnaire <[email protected]>
Signed-off-by: Thomas Gazagnaire <[email protected]>
Mainly support for solaris and some windows changes.. Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
carry-pr-22228
branch
from
b6918ed to
b2db005
Compare
|
@jhowardmsft rebased 👼 |
7 participants
Carry PR #22228 🐸.
Resolving conflicts wasn't easy, let's see if my missed something or not 👼
Closes #22228
- What I did
I've renamed the occurrences of
GraphDriverbyStorageDriverin the code base to be more consistent with the docs.The only externally-visible change of that PR is a direct API translation of the experimental storage driver plugins API
- How I did it
I've renamed things via grep/replace but I tried to do that carefully, so variable names and comments are also kept consistent.
- How to verify it
I've run
makeandmake testand it seems to work. I need to update docker/go-plugins-helpers#42 to use the new StorageDriver naming scheme, I'll do that once/if that PR is merged.I've tried to run the integration tests for the CLI. The experimental storage driver plugins seem broken (see below).
- A picture of a cute animal (not mandatory but encouraged)