Add support for mounting individual files from the host.#2301
Closed
amckinley wants to merge 1 commit intomoby:masterfrom
Closed
Add support for mounting individual files from the host.#2301amckinley wants to merge 1 commit intomoby:masterfrom
amckinley wants to merge 1 commit intomoby:masterfrom
Conversation
This involves docker checking the host filesystem to see whether the mount parameter refers to a file or directory, and so has the sideeffect that missing mount locations on the host are now grounds for an error from docker. (Previously this went unremarked upon until lxc died, and the error message ended up in the container logs instead of being reported to the terminal that ran docker.)
Member
|
LGTM but I am not the maintainer here :) /cc @crosbymichael |
Contributor
|
@amckinley @heavenlyhash I'm getting a test failure when running docker in docker. |
Contributor
|
@amckinley @heavenlyhash same test error, can you look into this? |
Contributor
|
Hi @amckinley just a gentle reminder that we are waiting on you to look at that test fail. Are you still interested in getting this merged? Are you aware of any ways this might break reverse compatibility? Thanks |
This was referenced Nov 12, 2013
Contributor
|
I've fixed the unit test in my pull request: #2672 . |
This was referenced Nov 14, 2013
Contributor
|
Closing this infavor of #2301 |
Member
|
@crosbymichael but this is 2301 :) |
Contributor
|
I mean #2775 sorry, wrong copy and paste of the PR id |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is just a rebase of #1757