Conversation
Member
|
LGTM (am I unofficially filling in here?) |
Contributor
Author
|
@fkautz could you take a look please ? |
commands.go
Outdated
Contributor
There was a problem hiding this comment.
Do you think we should go ahead and return the error here if we cannot copy to cli.out?
Contributor
Author
|
@crosbymichael I updated the PR following your advices |
Contributor
|
LGTM |
cpuguy83
pushed a commit
to cpuguy83/docker
that referenced
this pull request
May 25, 2021
clarifications and typo fixes for the design documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
,Fixes #2044