Windows: Daemon default to Hyper-V containers on client#22774
Windows: Daemon default to Hyper-V containers on client#22774LK4D4 merged 1 commit intomoby:masterfrom
Conversation
lowenna
force-pushed
the
jjh/client
branch
2 times, most recently
from
6d767a9 to
666fb28
Compare
|
We haven't even officially started supporting Win10 yet and this issue is already a top hit... This should help a lot! |
|
Looks good. |
|
@thaJeztah Can this be moved to code review? Thx. |
|
@jhowardmsft oh! Yes, I think it can |
| if containertypes.Isolation(val).IsHyperV() { | ||
| daemon.defaultIsolation = containertypes.Isolation("hyperv") | ||
| } | ||
| if containertypes.Isolation(val).IsProcess() { |
There was a problem hiding this comment.
Shouldn't this be moved to IsValid()? IIUC for this type of daemon, "process" isolation simply isn't a valid option
There was a problem hiding this comment.
TBH both are equally valid. I prefer it here as strictly the option chosen is a valid recognised option for isolation which is what that function is checking. I don't mind either way though, just as I say prefer it here.
There was a problem hiding this comment.
Alright, possibly just a matter of preference 👍
Signed-off-by: John Howard <[email protected]>
|
Docs updated. @neilpeterson FYI for matching Microsoft side docs. |
|
LGTM, thanks! |
|
Ok, so there will be a docker daemon running on Windows 10 (client) which will only work with hyper-v, is that right? |
|
Yes. |
|
LGTM |
7 participants
Signed-off-by: John Howard [email protected]
Fixes https://github.com/Microsoft/Virtualization-Documentation/issues/200. On client SKUs, sets the default isolation to Hyper-V and errors out if set to process, as client does not support Windows server containers. No change to server SKUs.
@mebersol @taylorb-microsoft