@GordonTheTurtle my commit is signed already :(

@caarlos0 I don't see a signature in your commit.

my commit is signed, don't know why it is complaining about it

You signed it with GPG, but it needs a "signed-off-by .." in the commit message (docker commit -s). I usually do docker commit -s -S

@thaJeztah ohh, got it, fixed. Thanks =)

From a Logentries perspective everything looks fine, bsphere's lib is reliable and has been for a very long time. The only caveat though is that the logs do not send over SSL which is a bit sad tbh :(

@StephenHynes7 Yeah :(

@StephenHynes7 any lib that supports SSL?

I'm not too familiar with logentries.com, @cpuguy83 told me it also implements syslog, so would there be downsides to using syslog instead of this driver?

Basically, we want to limit the amount of new logging drivers, and prefer to only add ones that are really necessary (until we have a system in place to allow external logging drives)

@thaJeztah It would require to have syslog installed, configured and running on the docker host...

I guess having the log driver in docker itself gives more power because the user can send logs to different accounts in different containers, etc...

@caarlos0 > any lib that supports SSL?

There is but I think the GO library is worth going forward with, I will look to see if I can create a PR for SSL option for it and we can see what happens.

@StephenHynes7 nice! Thanks

@caarlos0 fyi I have a PR to add tls support for the log library once that is merged then I would be happy here.

@StephenHynes7 Nice, I'll take a look!

Okay so now this driver will send logs over TLS so as far as Logentries is concerned we are good 👍

@StephenHynes7 I'll update the submodule here

@caarlos0 can you check the "vendor" failure to see if it's genuine? Looks like the vendor-check found a difference between the actually vendored files and the ones it's expecting;

13:38:39 The result of ./hack/vendor.sh differs
13:38:39 
13:38:39  D vendor/src/github.com/bsphere/le_go/.gitignore
13:38:39  D vendor/src/github.com/bsphere/le_go/.travis.yml
13:38:39  D vendor/src/github.com/bsphere/le_go/README.md
13:38:39  D vendor/src/github.com/bsphere/le_go/certs.go
13:38:39  D vendor/src/github.com/bsphere/le_go/le.go
13:38:39  D vendor/src/github.com/bsphere/le_go/le_test.go

@thaJeztah yeah, I need some help on that I guess..

I cloned the module inside the vendor folder and removed the .git folder, then added it to the hack/vendor.sh

Is that the correct way of doing this?

Basically, you usually edit the script, then run it. This may take a while though (and I'm not sure it works correctly if you're running on OS X); alternatively you can fix by adding/removing the files mentioned above :-)

@thaJeztah If I run the script, basically all vendors change... don't know why.

I'll try to comment the others and leave only le_go and then run it.

Definitely no problem with adding this driver. Library is clean and super tiny, but we really need to follow good practices and not embed the certificate in docker's code base.

I just opened a PR removing the certificates from the le_go lib: bsphere/le_go#12

@cpuguy83 Updated the le_go submodule, vendored and rebased commits with master.

LGTM

Oh except vendor is not quite right:

19:04:42 The result of ./hack/vendor.sh differs
19:04:42 
19:04:42  D vendor/src/github.com/bsphere/le_go/le_test.go
19:04:42 
19:04:42 Please vendor your package with ./hack/vendor.sh.

@cpuguy83 oops

@cpuguy83 should be good now

re-LGTM.

ping? (I just merged it again with master)

LGTM.

Moving to doc review.

re-ping @thaJeztah

@thaJeztah

Seems like I deleted my fork and github lost track of the PR.

I tried re-create the fork and the branch from the pull request ref (refs/pull/22699/head) and push it again, but it doesn't seem to be working.

Should I open another pr?

@caarlos0 yes, probably not possible to update the PR if you had to create a new branch. Let me know when it's up then we can link to it, and close this one

@thaJeztah I just created a PR for the docs in docker/docs#244

@thaJeztah #27471. Can I close this one?

Yes, let's close, thanks!