Skip to content

Vendor distribution to correct config blob media type in schema2 manifest#21949

Merged
cpuguy83 merged 1 commit intomoby:masterfrom
aaronlehmann:vendor-distribution-1622
Apr 13, 2016
Merged

Vendor distribution to correct config blob media type in schema2 manifest#21949
cpuguy83 merged 1 commit intomoby:masterfrom
aaronlehmann:vendor-distribution-1622

Conversation

@aaronlehmann
Copy link

@nwt noticed that the media type specified in the config section of a
schema2 manifest is application/octet-stream, instead of the correct
value application/vnd.docker.container.image.v1+json.

This brings in distribution/distribution#1622 to fix
this.

…fest

@nwt noticed that the media type specified in the config section of a
schema2 manifest is application/octet-stream, instead of the correct
value application/vnd.docker.container.image.v1+json.

This brings in distribution/distribution#1622 to fix
this.

Signed-off-by: Aaron Lehmann <[email protected]>
@aaronlehmann
Copy link
Author

@dmp42 inquired about getting this into 1.11. It fixes a spec compliance issue with the manifests generated by docker push. There are no user-facing problems with the manifests that reference the incorrect content type, but it would be nice if 1.11 produced manifests without this deviation from the spec. If it's too late for 1.11, nothing especially bad will happen.

ping @icecrime

@calavera
Copy link
Contributor

I'm pretty sure it's too late. But I'll leave it up to others.

Change LGTM

@dmcgowan
Copy link
Member

LGTM

1 similar comment
@cpuguy83
Copy link
Member

LGTM

@cpuguy83 cpuguy83 merged commit 40502e3 into moby:master Apr 13, 2016
@aaronlehmann aaronlehmann deleted the vendor-distribution-1622 branch April 13, 2016 02:12
@thaJeztah
Copy link
Member

if it's not strictly needed, I prefer to skip this for 1.11.0 indeed; we may reconsider for a patch release, but also if needed

@thaJeztah
Copy link
Member

ping @mlaventure @tiborvass think we can include this into 1.11.1?

@mlaventure
Copy link
Contributor

I'd say it's a good candidate, yes.

@thaJeztah
Copy link
Member

let me add it; we can go through the milestone if we decide to do a 1.11.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants