Build deb package for all Raspberry Pi's / raspbian-jessie #21895

StefanScherer · 2016-04-08T22:32:58Z

- What I did

Compile the Docker Engine 1.11 and build a deb package for Raspbian that is working for all eight million Raspberry Pi's, beginning with RPi 1, RPi 2, RPi 3 and should also work with RPi zero.

- How I did it

Take the contrib/builder/armhf/debian-jessie/Dockerfile for ARMv7 and use a Raspbian Docker image and set GOARM to 6 instead of 7 to build ARMv6 compatible binaries.

- How to verify it

Run make deb on an ARM machine, this can be ARMv6 or ARMv7. This build works eg. on Scaleway C1 servers.

Install it on a Raspbian LITE image:

$ echo "overlay" | sudo tee -a /etc/modules
$ sudo modprobe overlay
$ sudo apt-get install -y libapparmor1
$ sudo raspi-config
# reboot required for resizing SD card
$ sudo dpkg -i docker-engine_1.11*jessie_armhf.deb

Install it on HypriotOS for Raspberry Pi:

$ sudo apt-get remove -y docker-hypriot
$ sudo dpkg -i docker-engine_1.11*jessie_armhf.deb

- A picture of a cute animal (not mandatory but encouraged)

Successful installation on a Raspberry Pi (1) Model B with Raspbian LITE SD card image from the Raspberry Pi Foundation.

Would be great if we can add this Dockerfile to the 1.11 release so we can get rid of our proprietary build steps and start using docker-engine package instead of docker-hypriot package :-)

Signed-off-by: Stefan Scherer [email protected]

StefanScherer · 2016-04-08T22:33:53Z

This PR depends on the fix #21819 to build the deb packages.

Govinda-Fichtner · 2016-04-08T22:42:35Z

@StefanScherer 👯

thaJeztah · 2016-04-08T22:51:56Z

Would be great if we can add this Dockerfile to the 1.11 release so we can get rid of our proprietary build steps and start using docker-engine package instead of docker-hypriot package :-)

@StefanScherer you want us to also ship the .deb through apt.dockerproject.org for 1.11 ?

StefanScherer · 2016-04-08T23:02:26Z

@thaJeztah I have seen that the contrib/builder/deb structure has made it into 1.11 so I thought of adding the Dockerfile. So everyone can build the Docker Engine for the RPi on an ARM device without any patches

$ git clone https://github.com/docker/docker
$ cd docker
$ make deb

Adding the deb to apt.dockerproject.org would be fantastic, but to be realistic I think this is too close to the 1.11 release. But for the long term this would help, eg. improving docker-machine binary to support "raspbian" beside the "debian" distro to also just download the ARM package from there.

thaJeztah · 2016-04-08T23:05:43Z

@StefanScherer thanks; I have no real objection against adding the Dockerfile, but let me check if that would also automatically result in it being build during the release process. I'm indeed not comfortable with shipping binaries / debs for 1.11 this soon before the release, but adding a Dockerfile so that people can build it themselves sounds ok with me

DieterReuter · 2016-04-09T08:55:22Z

@StefanScherer 👏
@thaJeztah with this step we really can "build - ship - run" even the Docker engine the Docker way. Then everybody can build the Docker engine for ARMv6 and ARMv7 and could install and run it on a large variety of ARM devices - no matter the installed OS (Raspbian, Armbian, HypriotOS, ...). And in the long run it would be fantastic to get it built and shipped through the Docker release process.

thaJeztah · 2016-04-11T10:54:56Z

@tiborvass I'll add this to the 1.11 milestone; but only if we can include this without it being automatically resulting in debs to be published on apt.dockerproject.org

icecrime · 2016-04-11T15:08:59Z

@tiborvass I'll add this to the 1.11 milestone; but only if we can include this without it being automatically resulting in debs to be published on apt.dockerproject.org

I read this as "let's include it only if it makes no difference", so if you don't mind we'll just not include it and save us a cherry-pick ;-)

thaJeztah · 2016-05-05T15:09:15Z

ping @tiborvass @tianon @kencochrane PTAL!

kencochrane · 2016-05-05T15:25:35Z

LGTM

tiborvass · 2016-05-05T19:10:37Z

I am not sure what level of "official" release we want to give raspbian. Not that I'm against it, I just want to understand what this entails. /cc @icecrime

tiborvass · 2016-05-05T19:21:25Z

contrib/builder/deb/armhf/raspbian-jessie/Dockerfile

this should be using an official image

I agree, but we probably need an ARMv6 compatible base image here. The armhf/debian:jessie is for ARMv7. I'm not sure if the ENV GOARM 6 below is enough to have proper docker engine binaries for ARMv6.

No there is no guarantee that it will work correctly, eg we link to some C libraries that might have some uses of non compatible instructions in them. I think we would need an official raspbian image.

Why not armel/debian:jessie?
That one works with GOARM 6...

@luxas Thanks for the pointer. I haven't noticed these Docker images. I'll try that.

Those should be used with GOARM 5 I think but that is one option.

In contrib/builder/deb/armhf/raspbian-jessie/Dockerfile
#21895 (comment):

@@ -0,0 +1,11 @@
+FROM resin/rpi-raspbian:jessie

Why not armel/debian:jessie?
That one works with GOARM 6...

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/21895/files/fa10270f1fd14958c3a95adc99131408cd700226#r63225616

The build of the resin/rpi-raspbian Docker images is quite clean, small and well documented in this repo https://github.com/resin-io-library/resin-rpi-raspbian. I'd like to suggest to use these ones. The builds can be run on an Intel build server and therefore could be used for official images, too.

+100 for an official raspbian image.

icecrime · 2016-05-11T17:23:34Z

LGTM

thaJeztah · 2016-05-12T16:54:18Z

ping @tiborvass you wanted to have an official image; are you ok with moving this forward, or rather not?

StefanScherer · 2016-05-19T20:55:24Z

I've tested a build with FROM armel/debian:jessie, but then we have problems with the prebuilt Go tar.gz ( https://jenkins.hypriot.com/job/armhf-docker/1/console ).

Instead of investigating further how to make this work with armel, an official raspbian base image would help more people. @firecyberice has done this for us internally some time ago and we could help build such an official image.

Using the resin base image still works building eg. docker 1.11.1 ( see artifacts at https://jenkins.hypriot.com/job/armhf-docker/2/ )

thaJeztah · 2016-05-19T21:40:18Z

ping @tianon wdyt?

justincormack · 2016-05-27T20:50:59Z

contrib/builder/deb/armhf/raspbian-jessie/Dockerfile

This now needs updating in line with arm/jessie f32ccb0#diff-0eafa589a244859aba06e5c8a1b522fc

dmp42 · 2016-05-27T20:52:53Z

Just checked with @justincormack about this - very exciting!!!

Not going with armel is fine

In addition to @justincormack comments (about golang): @tianon what is the process for resin/rpi-raspbian to become an official image?

Would love to see this merged ASAP :)

Signed-off-by: Stefan Scherer <[email protected]>

justincormack · 2016-05-27T21:06:58Z

Have scheduled an arm build. I would be happy to see this merged without an official raspbian image in the short term, but I do think it would be great to have an official raspbian image, and it should be pretty straightforward as it is basically the same as jessie/arm.

justincormack · 2016-05-27T21:08:15Z

LGTM if the arm build passes.

justincormack · 2016-05-28T00:48:15Z

The arm build has passed, looks good.

thaJeztah · 2016-05-28T10:48:28Z

I'm gonna LGTM this; Having official builds for rPi is a great thing to have; we may want to add some information somewhere to what extend we consider it "officially supported", and/or mention it's still early, so "here may be some dragons"

DieterReuter · 2016-05-29T09:18:28Z

🚀 Cool, now the next milestone on the way to an official ARM support is reached!

Govinda-Fichtner · 2016-05-30T05:08:14Z

Very cool! This will be an awesome 📦 .

GordonTheTurtle added the status/0-triage label Apr 8, 2016

thaJeztah added status/2-code-review and removed status/0-triage labels Apr 8, 2016

thaJeztah added this to the 1.11.0 milestone Apr 11, 2016

icecrime removed this from the 1.11.0 milestone Apr 11, 2016

tiborvass reviewed May 5, 2016
View reviewed changes

justincormack reviewed May 27, 2016
View reviewed changes

StefanScherer added 2 commits May 27, 2016 22:54

Build deb for raspbian-jessie

46c6149

Signed-off-by: Stefan Scherer <[email protected]>

Update golang 1.6.2

d59458c

Signed-off-by: Stefan Scherer <[email protected]>

StefanScherer force-pushed the add-raspbian-jessie-deb branch from fa10270 to d59458c Compare May 27, 2016 21:00

thaJeztah merged commit 02caa73 into moby:master May 28, 2016

StefanScherer deleted the add-raspbian-jessie-deb branch May 28, 2016 11:35

StefanScherer mentioned this pull request May 30, 2016

build armhf deb for ubuntu-trusty #22152

Merged

StefanScherer mentioned this pull request Jun 15, 2016

Build-deb hack for systemd tasksmax #21628

Merged

StefanScherer mentioned this pull request Jul 20, 2017

Add Raspbian deb packages docker/docker-ce-packaging#11

Merged

Build deb package for all Raspberry Pi's / raspbian-jessie #21895

Build deb package for all Raspberry Pi's / raspbian-jessie #21895

Uh oh!

Conversation

StefanScherer commented Apr 8, 2016

Uh oh!

StefanScherer commented Apr 8, 2016

Uh oh!

Govinda-Fichtner commented Apr 8, 2016

Uh oh!

thaJeztah commented Apr 8, 2016

Uh oh!

StefanScherer commented Apr 8, 2016

Uh oh!

thaJeztah commented Apr 8, 2016

Uh oh!

DieterReuter commented Apr 9, 2016

Uh oh!

thaJeztah commented Apr 11, 2016

Uh oh!

icecrime commented Apr 11, 2016

Uh oh!

thaJeztah commented May 5, 2016

Uh oh!

kencochrane commented May 5, 2016

Uh oh!

tiborvass commented May 5, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

icecrime commented May 11, 2016

Uh oh!

thaJeztah commented May 12, 2016

Uh oh!

StefanScherer commented May 19, 2016

Uh oh!

thaJeztah commented May 19, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmp42 commented May 27, 2016

Uh oh!

justincormack commented May 27, 2016

Uh oh!

justincormack commented May 27, 2016

Uh oh!

justincormack commented May 28, 2016

Uh oh!

thaJeztah commented May 28, 2016

Uh oh!

DieterReuter commented May 29, 2016

Uh oh!

Govinda-Fichtner commented May 30, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants