Windows: So long TP4, so long...#21777
Merged
cpuguy83 merged 1 commit intomoby:masterfrom Apr 8, 2016
Merged
Conversation
Member
Author
Member
|
❤️ and it's 💚 on WindowsTP5! |
Member
|
Guess we need this in the 1.11 branch? |
Member
Author
|
@thaJeztah No, no, no, no, no. This must NOT be cherry-picked for 1.11! |
Signed-off-by: John Howard <[email protected]>
Contributor
|
Yeesssssssssss! 👍 What about the boilerplate code to retry on "object not found" errors and such? |
Member
|
@jhowardmsft oh! sorry for the confusion; I thought the TP4 CI would be replaced with TP5, so this was needed to have it run on the bump branch |
Member
Author
|
@icecrime some will still be needed until we have some servicing fixes for TP5. There's a lot more tidying to do yet, this predominantly is just the initial block to stop master on TP4. |
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard [email protected]