Skip to content

set the default storage driver as the users current default#21474

Merged
tonistiigi merged 1 commit intomoby:masterfrom
jessfraz:fastness-for-the-storage-driver-gods
Mar 25, 2016
Merged

set the default storage driver as the users current default#21474
tonistiigi merged 1 commit intomoby:masterfrom
jessfraz:fastness-for-the-storage-driver-gods

Conversation

@jessfraz
Copy link
Copy Markdown
Contributor

@jessfraz jessfraz commented Mar 24, 2016

- What I did

Made it so if you dont specify DOCKER_GRAPHDRIVER on make it will use your current, so say overlay in overlay or aufs in aufs, zfs in zfs, and if you are running anything else you are effed already :P

- How I did it

Makefile rule

- How to verify it

make

or override the default

DOCKER_GRAPHDRIVER=vfs make

- A picture of a cute animal (not mandatory but encouraged)

c732z

Signed-off-by: Jess Frazelle [email protected]

@jessfraz jessfraz force-pushed the fastness-for-the-storage-driver-gods branch from 940c6d7 to 54aa3a3 Compare March 24, 2016 16:41
@calavera
Copy link
Copy Markdown
Contributor

calavera commented Mar 24, 2016

LGTM

@vdemeester
Copy link
Copy Markdown
Member

vdemeester commented Mar 24, 2016

LGTM 🐯

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Mar 24, 2016

Looks like this node RHEL7 (devicemapper) (selinux-enabled) (i-bf547278) is/was out of disk space; https://jenkins.dockerproject.org/job/Docker-PRs-experimental/16931/console

17:18:19 FAIL: docker_cli_run_unix_test.go:852: DockerSuite.TestRunSeccompDefaultProfile
17:18:19 
17:18:19 docker_cli_run_unix_test.go:894:
17:18:19     c.Assert(err, checker.IsNil)
17:18:19 ... value *errors.errorString = &errors.errorString{s:"expected Operation not permitted, got: /go/src/github.com/docker/docker/bundles/1.11.0-dev/test-integration-cli/../binary/docker: Error response from daemon: Untar re-exec error: exit status 1: output: open /usr/bin/gpgv: no space left on device.\nSee '/go/src/github.com/docker/docker/bundles/1.11.0-dev/test-integration-cli/../binary/docker run --help'.\n"} ("expected Operation not permitted, got: /go/src/github.com/docker/docker/bundles/1.11.0-dev/test-integration-cli/../binary/docker: Error response from daemon: Untar re-exec error: exit status 1: output: open /usr/bin/gpgv: no space left on device.\nSee '/go/src/github.com/docker/docker/bundles/1.11.0-dev/test-integration-cli/../binary/docker run --help'.\n")
17:18:19

@tonistiigi tonistiigi merged commit fc3d87f into moby:master Mar 25, 2016
@jessfraz jessfraz deleted the fastness-for-the-storage-driver-gods branch March 26, 2016 21:47
@thaJeztah thaJeztah mentioned this pull request Nov 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status/2-code-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jessfraz @calavera @vdemeester @thaJeztah @tonistiigi @icecrime @GordonTheTurtle