@tonistiigi: Tests need updates.

I'm hesitant about allowing unprefixed 64-bit IDs for some commands (run, rmi) and not allowing it for others (tag, push, pull, etc.). I think if we're declaring that 64-bit IDs are okay as long as they're not tag references, we should remove the check that prevents them in the reference package, and instead have a check in docker tag that disallows creating them.

cc @dmcgowan

If it is supported for run and rmi, then it should also be supported on tag. I would be more in favor of detecting when these un-prefixed IDs are used and add the prefix before parsing. Are we trying to say that a 64-bit ID should always be interpreted as if the "sha256:" was implied? If that is the case we should just add the implied prefix without changing any of the image config interpretation code.

allowing unprefixed 64-bit IDs for some commands (run, rmi) and not allowing it for others (tag, push, pull, etc.).

Push and pull don't allow image IDs. Tag already works correctly like run and rmi.

What's the status here?

Also, looks like tests are failing @tonistiigi

@aaronlehmann @dmcgowan I updated by adding a modified parser function for the cases where we allow both IDs and references but handle them bit differently. This maintains meaningful error messages and still catches invalid references. I think it's important to keep the distinction between IDs and refs and not just add extra validation on insertion to tagstore.

Updated daemon.GetImageID to use the new parse function as well. Note that there is no functionality update in this function, just makes sense to use the same code for both of them as they are very similar.

LGTM

This appears to have regressed in 17.04.0-ce

In version 17.03.1 using docker tag [:tag] works fine.

@samuraisam Can you open a new issue with the details?