LGTM

/cc @estesp

LGTM as long as janky is happy

@liron-l this looks good, but one minor nit is that the filename is misspelled for the new file you created. Right now it shows as: integration-cli/docker_cli_usrens_test.go

Maybe you can fix the name and also squash the 2 commits as it doesn't really need to be 2 different commits.

Thanks for this!

damn good catch :)

On Mon, Feb 8, 2016 at 1:56 PM, Phil Estes [email protected] wrote:

@liron-l https://github.com/liron-l this looks good, but one minor nit
is that the filename is misspelled for the new file you created. Right now
it shows as: integration-cli/docker_cli_usrens_test.go

Maybe you can fix the name and also squash the 2 commits as it doesn't
really need to be 2 different commits.

Thanks for this!

—
Reply to this email directly or view it on GitHub
#20117 (comment).

Jessie Frazelle
4096R / D4C4 DD60 0D66 F65A 8EFC 511E 18F3 685C 0022 BFF3
pgp.mit.edu http://pgp.mit.edu/pks/lookup?op=get&search=0x18F3685C0022BFF3

Fixed. Thanks @estesp good catch 👍

Job: Docker-PRs-WoW-TP4 FAILED:

---
056050.
+ ec=125
+ set +x

----------------------------------
ERROR: Failed to build test binary
----------------------------------



-----------------------------------------------
ERROR: Failed with exitcode 125 at Tue Feb  9 07:33:08 CUT 2016.
-----------------------------------------------


INFO: Tidying up at end of run
INFO: Nuking /d/CI
INFO: Zapped successfully
INFO: End of cleanup
INFO: Ended at Tue Feb  9 07:33:09 CUT 2016 (1m 13s)
Build step 'Execute shell' marked build as failure
[PostBuildScript] - Execution post build scripts.
[docker] $ sh -xe D:\temp\hudson5101380273849574846.sh
+ set +e
+ set +x
INFO: End of cleanup
Notifying endpoint 'HTTP:https://leeroy.dockerproject.org/notification/jenkins'
---

LGTM