Tests for PR # 19123: daemon option (--storage-opt dm.basesize) for increasing the base device size on daemon restart by shishir-a412ed · Pull Request #19661 · moby/moby

shishir-a412ed · 2016-01-25T14:32:31Z

Signed-off-by: Shishir Mahajan [email protected]

runcom · 2016-01-25T14:40:10Z

adding milestone 1.10 since the relative PR is in the milestone as well

runcom · 2016-01-25T14:43:33Z

integration-cli/docker_cli_daemon_test.go

not sure about this, maybe we need some testRequirement like this https://github.com/docker/docker/blob/master/integration-cli/requirements.go#L96

which tells us we are on devicemapper (I'm sure CI has a devicemapper build for master)

calavera · 2016-01-25T18:46:54Z

No need to have it in the milestone, since it only adds tests 😁

Thanks @shishir-a412ed!

shishir-a412ed · 2016-01-26T21:40:59Z

Regarding comment #19661 (comment)
I discussed it with @runcom . In order to use HTTP GET request for /info endpoint, s.d.sock() needs to be binded to the daemon object, which currently is not binded.

@calavera what do you think. you okay using docker -H s.d.sock() info|grep Base Device Size to extract the base device size or you want to use the HTTP GET request to extract that information ?

@runcom said he can make that change if we go for the latter option.

shishir-a412ed · 2016-02-02T16:14:11Z

@calavera @runcom
Any updates on this one ?

Shishir

jessfraz · 2016-02-04T01:49:43Z

integration-cli/docker_utils.go

can you maybe clean this up a bit, random carrige returns and vars should not be starting with a capital

I have changed the variable names to start with lowercase. The carriage returns are not random, they are in the output and needs to be trimmed. Otherwise the test fails.

jessfraz · 2016-02-04T01:53:18Z

integration-cli/docker_utils.go

why are you parsing it as a float only to convert it to an int two lines later

There is a difference between parsing and casting. strconv.ParseInt() would throw an error if a string with . ("12.59") is passed to it, which means a base device size of 12.59 cannot be directly parsed into an int. We need to parse it as a float and cast it into an int64.

jessfraz · 2016-02-04T21:38:09Z

integration-cli/docker_utils.go

can you maybe clean this up a bit, random carrige returns and vars should not be starting with a capital

Same as above.

cpuguy83 · 2016-02-05T16:26:27Z

integration-cli/docker_utils.go

:) This review comment is very hard to fix !

…ncreasing the base device size on daemon restart Signed-off-by: Shishir Mahajan <[email protected]>

calavera · 2016-02-09T23:28:53Z

LGTM

runcom · 2016-02-09T23:34:51Z

LGTM waiting on janky

Tests for PR # 19123: daemon option (--storage-opt dm.basesize) for increasing the base device size on daemon restart

…sesize) for increasing the base device size on daemon restart Signed-off-by: Shishir Mahajan <[email protected]>

GordonTheTurtle added the status/0-triage label Jan 25, 2016

runcom added status/2-code-review and removed status/0-triage labels Jan 25, 2016

shishir-a412ed force-pushed the tests_rootfs_pr branch from 173a610 to 3d3b033 Compare January 25, 2016 14:39

runcom added this to the 1.10.0 milestone Jan 25, 2016

runcom reviewed Jan 25, 2016
View reviewed changes

calavera removed this from the 1.10.0 milestone Jan 25, 2016

shishir-a412ed force-pushed the tests_rootfs_pr branch 4 times, most recently from 24c98ce to 1df00a8 Compare January 26, 2016 21:34

shishir-a412ed force-pushed the tests_rootfs_pr branch 6 times, most recently from 757292e to 937cd9e Compare February 2, 2016 16:13

shishir-a412ed force-pushed the tests_rootfs_pr branch from 937cd9e to 1904f69 Compare February 3, 2016 14:16

jessfraz reviewed Feb 4, 2016
View reviewed changes

shishir-a412ed force-pushed the tests_rootfs_pr branch from 1904f69 to 1e06779 Compare February 4, 2016 15:06

jessfraz reviewed Feb 4, 2016
View reviewed changes

cpuguy83 mentioned this pull request Feb 5, 2016

Create extpoint for graphdrivers #13777

Merged

shishir-a412ed force-pushed the tests_rootfs_pr branch 3 times, most recently from 477c04e to bce410e Compare February 5, 2016 16:17

cpuguy83 reviewed Feb 5, 2016
View reviewed changes

shishir-a412ed force-pushed the tests_rootfs_pr branch 3 times, most recently from 0edb40e to ccb987c Compare February 8, 2016 16:58

Tests for PR # 19123: daemon option (--storage-opt dm.basesize) for i…

0718459

…ncreasing the base device size on daemon restart Signed-off-by: Shishir Mahajan <[email protected]>

shishir-a412ed force-pushed the tests_rootfs_pr branch from ccb987c to 0718459 Compare February 9, 2016 15:47

runcom added status/4-merge and removed status/2-code-review labels Feb 9, 2016

calavera added a commit that referenced this pull request Feb 10, 2016

Merge pull request #19661 from shishir-a412ed/tests_rootfs_pr

321f291

Tests for PR # 19123: daemon option (--storage-opt dm.basesize) for increasing the base device size on daemon restart

calavera merged commit 321f291 into moby:master Feb 10, 2016

calavera deleted the tests_rootfs_pr branch February 10, 2016 01:30

Conversation

shishir-a412ed commented Jan 25, 2016

Uh oh!

runcom commented Jan 25, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

calavera commented Jan 25, 2016

Uh oh!

shishir-a412ed commented Jan 26, 2016

Uh oh!

shishir-a412ed commented Feb 2, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

calavera commented Feb 9, 2016

Uh oh!

runcom commented Feb 9, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants