bugfix: prevent creating network 'default'#19431
Merged
coolljt0725 merged 1 commit intomoby:masterfrom Jan 19, 2016
Merged
Conversation
Member
|
change LGTM, should we have some tests? /cc @mavenugo |
Contributor
Author
|
Yeah, test is coming |
Default is predefined network and is reserved, so we should stop user from creating network with name `default` Signed-off-by: Zhang Wei <[email protected]>
WeiZhang555
force-pushed
the
19422-default-network
branch
from
45a6890 to
31dae44
Compare
Contributor
|
LGTM. |
Contributor
|
LGTM |
Member
|
It's a small change, so think we can cherry pick this into the release |
coolljt0725
added a commit
that referenced
this pull request
Jan 19, 2016
bugfix: prevent creating network 'default'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default is predefined network and is reserved, so we should stop user
from creating network with name
defaultSigned-off-by: Zhang Wei [email protected]