extend mirror for supporting private registry#19009
extend mirror for supporting private registry#19009TrumanLing wants to merge 1 commit intomoby:masterfrom TrumanLing:extend-mirror-for-private-registry
Conversation
|
You don't need to open a new PR for rebase, just |
Signed-off-by: Ling FaKe <[email protected]>
|
I'd really like to have input of @dmp42 @stevvooe, @RichardScothern for "registry" and @tonistiigi for the engine side on this |
|
To add support for this, we need to make it so that image names are scoped by their registry if they are not from the official registry. We also need content trust to be enabled by default, since this defers naming to a possibly untrusted registry. Such a PR really needs a proper proposal outlining the approach to these concerns before proceeding. I believe my most recent description of this issue is in this post. |
|
@stevvooe I know your concers, but I don't understand completely, the image names, image trust and provenance and layers collide you mentioned in docker/docker#16974, as for layer collide, do you mean same name(from different repositories) but different content? What application case cause layers collide? Would you please show me more detailed with issues about image names, image trust and provenance? it will be appreciated if some diagram. |
|
@thaJeztah @stevvooe though there is naming scope issue, but I think this PR has no direct relationship with your concerns, and there is strong and much desire for mirroring private registry, how about your opinion? |
|
@TrumanLing If registry A and registry B disagree on what the value of image Also, this needs a description of the actual proposal. This PR changes the format and behavior of an existing option and doesn't even demonstrate why or how. Let's see a design and proposal covering these concerns and move from there. |
|
@stevvooe thanks for your reponse. If you do desgin, proposal and discussion, would you please involve me if convinient, I am very interesting to these conerns. |
|
@TrumanLing I think @stevvooe meant to say; if you want this feature, please create a design and proposal |
|
We already have a proposal: #18818 |
|
@hqhq Could you expand the proposal to cover the concerns above? Specifically, what is the planned behavior in the daemon upon disagreement in naming. These questions need to be answered before we can proceed. |
|
@thaJeztah @stevvooe you mentioned " If registry A and registry B disagree on what the value of image |
|
@TrumanLing The proposal is insufficient. Please expand it to cover these cases and analyze other cases that may arise. We cannot accept a change here without proper due diligence. |
|
Let's continue discussion on the related issue #18818: I'm closing this for now as it doesn't seem ready to be merged. Thanks |
extend mirror for supporting private registry
Signed-off-by: Ling FaKe [email protected]