extend mirror for supporting private registry#18915
Closed
TrumanLing wants to merge 1 commit intomoby:masterfrom
TrumanLing:extend-mirror-for-private-registry
Closed
extend mirror for supporting private registry#18915TrumanLing wants to merge 1 commit intomoby:masterfrom TrumanLing:extend-mirror-for-private-registry
TrumanLing wants to merge 1 commit intomoby:masterfrom
TrumanLing:extend-mirror-for-private-registry
Conversation
Contributor
Author
Contributor
|
There are compile errors in test files. |
Contributor
Author
|
There is one error in This error looks like nothing with my PR. |
Signed-off-by: Ling FaKe <[email protected]>
Member
|
@TrumanLing looks like this needs a rebase; GitHub reports that there are merge conflicts |
Member
|
I'd really like to have input of @dmp42 @stevvooe, @RichardScothern for "registry" and @tonistiigi for the engine side on this |
Contributor
Author
|
@thaJeztah thx for your reponse, and I will rebase it, and want to hear opinions form them( @dmp42 @stevvooe, @RichardScothern and @tonistiigi ) as well. |
Contributor
Author
|
@thaJeztah I have rebased it, and make a new PR #19009, please refer. Any problem, free to contact me:)))) |
Member
|
I'll close this one then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extend mirror for supporting private registry
Signed-off-by: Ling FaKe [email protected]