Skip to content

extend mirror for supporting private registry#18915

Closed
TrumanLing wants to merge 1 commit intomoby:masterfrom
TrumanLing:extend-mirror-for-private-registry
Closed

extend mirror for supporting private registry#18915
TrumanLing wants to merge 1 commit intomoby:masterfrom
TrumanLing:extend-mirror-for-private-registry

Conversation

@TrumanLing
Copy link
Copy Markdown
Contributor

extend mirror for supporting private registry

Signed-off-by: Ling FaKe [email protected]

@TrumanLing
Copy link
Copy Markdown
Contributor Author

#18818

@hqhq
Copy link
Copy Markdown
Contributor

hqhq commented Dec 26, 2015

There are compile errors in test files.

@TrumanLing
Copy link
Copy Markdown
Contributor Author

There is one error in test-integration-cli for windows as following:

FAIL: docker_cli_build_test.go:6489: DockerSuite.TestBuildTagEvent

docker_cli_build_test.go:6515:
    c.Fatal(observer.TimeoutError("test:latest", "tag"))
... Error: failed to observe event `tag` for test:latest
2015-12-30T01:34:23.150853887Z testbuildsymlinkbreakout:latest: tag

This error looks like nothing with my PR.

@thaJeztah
Copy link
Copy Markdown
Member

@TrumanLing looks like this needs a rebase; GitHub reports that there are merge conflicts

@thaJeztah
Copy link
Copy Markdown
Member

I'd really like to have input of @dmp42 @stevvooe, @RichardScothern for "registry" and @tonistiigi for the engine side on this

@TrumanLing
Copy link
Copy Markdown
Contributor Author

@thaJeztah thx for your reponse, and I will rebase it, and want to hear opinions form them( @dmp42 @stevvooe, @RichardScothern and @tonistiigi ) as well.

@TrumanLing
Copy link
Copy Markdown
Contributor Author

@thaJeztah I have rebased it, and make a new PR #19009, please refer. Any problem, free to contact me:))))

@thaJeztah
Copy link
Copy Markdown
Member

I'll close this one then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants