Replace pkg/units with docker/go-units.#18682
Merged
calavera merged 2 commits intomoby:masterfrom Dec 16, 2015
Merged
Conversation
calavera
force-pushed
the
replace_units_package
branch
from
009748d to
21ef0b3
Compare
calavera
force-pushed
the
replace_units_package
branch
from
21ef0b3 to
c08d40a
Compare
Member
|
LGTM |
Member
|
LGTM 🐮 |
Contributor
Author
|
I was wrong, and libcontainer introduced a breaking change 😔 |
Contributor
Author
|
I opened a PR in runc: opencontainers/runc#436 |
Member
|
😓 |
calavera
force-pushed
the
replace_units_package
branch
from
c08d40a to
c2c58e8
Compare
Contributor
Author
|
libcontainer is fixed already. I pulled the changes with the new SHA here. |
calavera
force-pushed
the
replace_units_package
branch
from
c2c58e8 to
7432f7a
Compare
Contributor
|
@calavera please separate vendoring commit |
Libcontainer depends on the new package now to avoid cycled dependencies. Signed-off-by: David Calavera <[email protected]>
Signed-off-by: David Calavera <[email protected]>
calavera
force-pushed
the
replace_units_package
branch
from
7432f7a to
4fef42b
Compare
Contributor
Author
|
@tiborvass done. |
Member
|
I noticed go-units has the ulimit stuff too. |
Contributor
Author
|
@cpuguy83 yes. |
Contributor
Author
|
the ulimits change is going to be a separated PR because it affects runconfig, which I'm working on right now. |
Member
|
LGTM |
1 similar comment
Contributor
|
LGTM |
calavera
added a commit
that referenced
this pull request
Dec 16, 2015
Replace pkg/units with docker/go-units.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add minor dependency update from libcontainer to remove circular dependencies. It won't be the last time we update libcontainer before the next major release, I think we should be okay bumping the dependency to a commit SHA here. There has only been a refactoring change between our tag and the the new SHA that doesn't modify, add or remove functionality.
Signed-off-by: David Calavera [email protected]