Skip to content

Comments

loopback (and devicemapper) cleanup#18651

Merged
calavera merged 2 commits intomoby:masterfrom
vbatts:dm-cleanup
Dec 18, 2015
Merged

loopback (and devicemapper) cleanup#18651
calavera merged 2 commits intomoby:masterfrom
vbatts:dm-cleanup

Conversation

@vbatts
Copy link
Contributor

@vbatts vbatts commented Dec 14, 2015

There is no logic change here, re-arrange and cleanup.

The loopback logic is not technically exclusive to the devicemapper driver. This reorganizes the code such that the loopback code is usable outside of the devicemapper package and driver.

ping @calavera @rhvgoyal @tiborvass

@rhvgoyal
Copy link
Contributor

@vbatts Do you have a user in mind who is planning to use loopback package?

@rhvgoyal
Copy link
Contributor

I think in general sounds like a good idea. If breaking existing users of devicemapper is not a concern, I think it should be fine to make this change.

@vbatts
Copy link
Contributor Author

vbatts commented Dec 14, 2015

@rhvgoyal i'm presently re-using the code myself, and found that it's useful, but I don't need the devicemapper package.
And yes, if there were existing users from pkg/devmapper they'd have to switch to pkg/loopback. Broken, but not devastating.

@runcom
Copy link
Member

runcom commented Dec 18, 2015

@vbatts needs rebase :(

The loopback logic is not technically exclusive to the devicemapper
driver. This reorganizes the code such that the loopback code is usable
outside of the devicemapper package and driver.

Signed-off-by: Vincent Batts <[email protected]>
@vbatts
Copy link
Contributor Author

vbatts commented Dec 18, 2015

done

On Fri, Dec 18, 2015 at 10:10 AM, Antonio Murdaca [email protected]
wrote:

@vbatts https://github.com/vbatts needs rebase :(


Reply to this email directly or view it on GitHub
#18651 (comment).

@runcom
Copy link
Member

runcom commented Dec 18, 2015

LGTM, I doubt anyone out there uses pkg/devmapper (we broke pkg/... interfaces other times as well)

@calavera
Copy link
Contributor

LGTM

calavera added a commit that referenced this pull request Dec 18, 2015
loopback (and devicemapper) cleanup
@calavera calavera merged commit 54f9459 into moby:master Dec 18, 2015
@vbatts vbatts deleted the dm-cleanup branch April 27, 2016 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants