Add the memoryLimitSupport requirement to Events OOM tests#17913
Merged
runcom merged 1 commit intomoby:masterfrom Nov 11, 2015
Merged
Add the memoryLimitSupport requirement to Events OOM tests#17913runcom merged 1 commit intomoby:masterfrom
runcom merged 1 commit intomoby:masterfrom
Conversation
The docker run commands in these tests uses the -m flag, so the tests should require that it's supported to run. Fixes 17215 (maybe) Signed-off-by: Christy Perez <[email protected]>
Contributor
Author
|
This is as a result of investigating Issue #17215. While it won't fix any flakiness seen in the CI tests in docker's Jenkins env (since those instances support memory control, AFAICT), it does make sure it doesn't run on environments it shouldn't. |
Member
|
LGTM |
Member
|
LGTM 🐴 |
runcom
added a commit
that referenced
this pull request
Nov 11, 2015
Add the memoryLimitSupport requirement to Events OOM tests
tophj-ibm
added a commit
to tophj-ibm/moby
that referenced
this pull request
Feb 23, 2016
If cgroup swap memory limit isn't enabled, then the -m flag doesn't work and the container that is created for both of these tests is very large. Because we are trying to run the containers out of memory, this takes a very long time and causes the tests to fail most of the time. Follow-up to moby#17913 Signed-off-by: Christopher Jones <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docker run commands in these tests uses the -m flag,
so the tests should require that it's supported to run.
Signed-off-by: Christy Perez [email protected]