increase the maxJSONDecodeRetry in json log reader#17606
Merged
cpuguy83 merged 1 commit intomoby:masterfrom Nov 3, 2015
Merged
increase the maxJSONDecodeRetry in json log reader#17606cpuguy83 merged 1 commit intomoby:masterfrom
cpuguy83 merged 1 commit intomoby:masterfrom
Conversation
Signed-off-by: Shijiang Wei <[email protected]>
Contributor
Author
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
cpuguy83
added a commit
that referenced
this pull request
Nov 3, 2015
increase the maxJSONDecodeRetry in json log reader
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another try to fix the flaky tests
TestLogsFollowSlowStdoutConsumerandTestRunSlowStdoutConsumerThe previous one is #17537
I noticed another failure in one of the PRs after #17537 was merged but it seems that the test was re-triggered and I couldn't find the exact failed URL in jenkins.
If I add the following debug lines after https://github.com/docker/docker/blob/master/daemon/logger/jsonfilelog/jsonfilelog.go#L370
when the test fails, I can see the following error log:
After changed
maxJSONDecodeRetryto 20000 I run the test for 300 times locally and all succeed.Before the change it usually fails within 100 times.
/cc @cpuguy83 @LK4D4