Thanks, @vdemeester.

Two things, first:
The filters require capitalized names (.Name, .Containers) whereas the raw output of docker network inspect has them in lowercase (.name, .containers).
This is different from docker inspect where the unfiltered command also contains the capitalized variants (.Id).
I think the output of the unfiltered docker network inspect was implemented incorrectly with all keys being lowercased. It seems to just print the JSON.

Second, not all keys are available. .Id and .Ipam do not work:

template: :1:2: executing "" at <.Ipam>: Ipam is not a field of struct type *types.NetworkResource

@albers It's probably because it needs to be ID and IPAM

Agreed, this is stinky, really we have the same issue on docker inspect.

Maybe we can just inspect against the raw json?

@cpuguy83 not sure what you mean on that ; reading the json and applying our template/format ?

I did the simplest implementation ever (which looks almost exactly as docker volume inspect too 😝)

Yeah, but volume inspect's json output matches the struct type...for now.

If you unmarshal to interface{} or even map[string]interface{} instead of the struct type, that's what I mean by using the raw json.

@cpuguy83 ok, sounds pretty good to me, I'll try that 😉

@cpuguy83 Using interface{} or map[string]interface make the json look like :

$ docker network inspect host
[
    {
        "containers": {},
        "driver": "host",
        "id": "0ef30effd29074809e8592e71b1a580f078ca12a4fe7c7f3447607df6f8087f8",
        "ipam": {
            "config": [],
            "driver": "default"
        },
        "name": "host",
        "options": {},
        "scope": "local"
    }
]

All lowercase, feels a little bit strange compared to othersinspect commands.

Edit: oh well, that's how it's specified in https://github.com/docker/docker/blob/master/api/types/types.go#L337 so.. might be ok then 😅.

I created an issue (#17519) that the output of docker network inspect should be changed to use the key names form the struct. This would improve consistency and should also ease implementaion of --format.

The api respects the types now and we don't need to use interfaces or maps here anymore 🎉

Rebased against master.

@calavera did the same as api/client/volume.go inspect for now 😛.

I just found another issue on this, since this PR hasn't been merged yet, I think it's better to modify in this commit. docker network inspect one non-exist network is inconsistent with docker inspect and docker volume inspect, for example:

$ docker inspect aaaa
Error: No such image or container: aaaa
[]

$ docker network inspect aaaa
Error: No such network: aaaa
null

$docker volume inspect aaaa
Error response from daemon: no such volume

I think it's better for them to have consistent behavior.
As @vdemeester is also adding --format for volume, I think I can leave opinions about volume here though it's not quite relevant to this PR. 😄

I agree with you @WeiZhang555. I think the best consistent behavior is to not print any inspect output if the object doesn't exist, like the volume command does.

This would mean :

$ docker network inspect aaaa bbbbb # where bbbbb exists
Error response from daemon: no such network: aaaa
[{
# // …
}]

I'm ok with that 😉. I'll update this PR to reflect that, and probably open more to get the behavior consistent on other inspect if needed.

❤️ ❤️

LGTM.

It will need documentation though 😜

@calavera updated with some docs 😉

ping @thaJeztah for docs, ping @albers @sdurrheimer for completion I just added 😉

thanks @vdemeester . LGTM

Updated, thanks guys @albers @sdurrheimer

LGTM

Thanks a lot, Vincent.
bash completion LGTM.

LGTM

moving to docs review ping @thaJeztah @moxiegirl

Thanks @vdemeester one note, but LGTM otherwise!

LGTM @vdemeester thank you! ⭐

@thaJeztah @moxiegirl updated 😉

Thanks! LGTM!