Conversation
|
@mavenugo @dave-tucker this is currently a WIP. You can check here. I'll push check points. EOD Sunday I'll make it through all of it. TODO: |
moxiegirl
changed the title
|
Updated with first pass at the Getting started with overlay. End-to-end testing of the final draft is going to have to wait until: a solution to #17047 is merged. |
|
@mavenugo @dave-tucker Updated also the getting started which is our tutorial for new users. Wanted them to start with networking rather than linking. |
|
TODO: Pare down old networking docs |
moxiegirl
force-pushed
the
new-networking-docs
branch
from
8f85804 to
dca966e
Compare
docs/extend/plugins.md
Outdated
There was a problem hiding this comment.
Just so you don't miss them; got some merge markers in here
moxiegirl
changed the title
|
@mavenugo @thaJeztah @dave-tucker @vdemeester Go ahead and review. Dave I have your changes and Madhu I have notes regarding:
|
moxiegirl
force-pushed
the
new-networking-docs
branch
from
6f37bfc to
09c2e95
Compare
|
@moxiegirl I put some suggestions in moxiegirl#1 over the weekend. Rebased so it makes more sense. |
docs/reference/commandline/run.md
Outdated
There was a problem hiding this comment.
Drop "simply"
"You can also container id" -> "you can also use the container id"
|
I think "Within of a user-defined bridge network, linking is not supported." is not true. I was able to link two containers that are part of a user-defined bridge network. |
|
In the "default bridge0 network in detail", without linking two container1 and container2 i dont think pinging using their name will work??? |
|
Duplicate "run" in |
|
Need to specify which kv paramters are actually required. cluster-advertise and cluster-store are actually both REQUIRED and listing them as options might be misleading. |
|
Just went through the doc and overall SGTM minor the typos and fixes suggested above. I was mostly reviewing the steps as a user and I think it's great for a first shot at the doc. As it is let's rebase and fix the typos if possible. This can always be improved (although it's practical to have all the suggestions here to fix them asap). And nicely done @moxiegirl :) |
Removing old networking.md Updating dockernetworks.md with images Adding information on network plugins Adding blurb about links to docker networking Updating the working documentation Adding Overlay Getting Started Downplaying links by removing refs/examples, adding refs/examples for network. Updating getting started to reflect networks not links Pulling out old network material Updating per discussion with Madhu to add Default docs section Updating with bridge default Fix bad merge Updating with new cluster-advertise behavior Update working and NetworkSettings examples Correcting example for default bridge discovery behavior Entering comments Fixing broken Markdown Syntax Updating with comments Updating all the links Signed-off-by: Mary Anthony <[email protected]>
moxiegirl
force-pushed
the
new-networking-docs
branch
from
df4e5b6 to
9ef855f
Compare
|
author LGTM |
|
Publishing for release. Good enough, not perfect. |
|
@tiborvass Ready for Cherry pick captain, my captain. |
|
Thanks so much, @moxiegirl ! |
Network docs for release Signed-off-by: Moorthy RS <[email protected]>
10 participants
Removing old networking.md
Updating dockernetworks.md with images
Adding information on network plugins
Adding blurb about links to docker networking
Updating the working documentation
Adding Overlay Getting Started
Downplaying links by removing refs/examples, adding refs/examples for network.
Updating getting started to reflect networks not links
Signed-off-by: Mary Anthony [email protected]