Windows: Enable kill (part one) #16963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM |
pkg/signal/signal_windows.go
Outdated
Member
There was a problem hiding this comment.
Missing some verb here 😅 : s/We these/We define these/ I guess 😉
Member
|
Except from the typo, LGTM 🐶 |
Signed-off-by: John Howard <[email protected]>
lowenna
force-pushed
the
10662-kill-partone
branch
from
f08f654 to
2dca1bc
Compare
Member
Author
|
Ugh, corrected comment. |
Member
|
LGTM waiting janky |
Member
|
janky is happy, merging |
cpuguy83
added a commit
that referenced
this pull request
Oct 13, 2015
Windows: Enable kill (part one)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard [email protected]
This is the first part (trying to keep to small PRs) of enabling docker kill on Windows. This part simply enables the use of SIGKILL and SIGTERM as constructs in the signal map. They don't actually relate to signals in the Unix sense, since Windows does not support signals.
This PR will actually start docker kill working against a Windows daemon, as opposed to erroring out immediately, just it will always go through an attempt at graceful shutdown, not the forced shutdown. That'll be fixed in part two...