Skip to content

Vendoring libnetwork integrated with Docker discovery service#16718

Merged
icecrime merged 2 commits intomoby:masterfrom
mavenugo:discovery
Oct 5, 2015
Merged

Vendoring libnetwork integrated with Docker discovery service#16718
icecrime merged 2 commits intomoby:masterfrom
mavenugo:discovery

Conversation

@mavenugo
Copy link
Copy Markdown
Contributor

@mavenugo mavenugo commented Oct 2, 2015

This PR brings in end to end discovery and cluster-store integration with docker.
With this PR and #16645, docker multi-host networking will exit experimental.

cc @icecrime

This commit brings in end to end integration of Docker Discovery with
libnetwork multi-host networking.

Signed-off-by: Madhu Venugopal <[email protected]>
@mavenugo
Copy link
Copy Markdown
Contributor Author

mavenugo commented Oct 3, 2015

@icecrime fixed the CI failures.
windows CI is failing on DockerSuite.TestExecStartFails which is not related to this change.

PTAL.

@mavenugo mavenugo force-pushed the discovery branch 2 times, most recently from 4c9448d to 139ea5b Compare October 4, 2015 06:59
@ibuildthecloud
Copy link
Copy Markdown
Contributor

Please merge soon 🙏

@icecrime
Copy link
Copy Markdown
Contributor

icecrime commented Oct 5, 2015

LGTM (Windows CI issue tracked here #16738).

@vdemeester
Copy link
Copy Markdown
Member

LGTM 🐼

icecrime pushed a commit that referenced this pull request Oct 5, 2015
Vendoring libnetwork integrated with Docker discovery service
@icecrime icecrime merged commit 33e9d70 into moby:master Oct 5, 2015
@ibuildthecloud
Copy link
Copy Markdown
Contributor

Woo Hoo!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants