Add missing Content-Type check to API Start Exec.#16399
Closed
matthewvalimaki wants to merge 4 commits intomoby:masterfrom
Closed
Add missing Content-Type check to API Start Exec.#16399matthewvalimaki wants to merge 4 commits intomoby:masterfrom
matthewvalimaki wants to merge 4 commits intomoby:masterfrom
Conversation
GordonTheTurtle
added
status/0-triage
dco/no
matthewvalimaki
force-pushed
the
master
branch
from
7170467 to
09f27e1
Compare
Signed-off-by: Matthew Valimaki <[email protected]>
matthewvalimaki
force-pushed
the
master
branch
from
09f27e1 to
2ba5883
Compare
GordonTheTurtle
removed
the
dco/no
Signed-off-by: Matthew Valimaki <[email protected]>
Member
|
All the exec tests are failing with this. |
Signed-off-by: Matthew Valimaki <[email protected]>
Signed-off-by: Matthew Valimaki <[email protected]>
Contributor
There was a problem hiding this comment.
This header is added in cli.call by default.
Member
|
Any news here? also this will need a rebase. |
Contributor
|
I'm going to close this since it looks like there is no movement here. I added the check in #17125 that should fix this problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The request content-type for Exec Start needs to be "application/json" and while the Docker API does check content-type for Exec Create it was not checked for Exec Start. Using invalid content-type would lead to 500 error without explanation. The proposed change adds this missing check and explanation if invalid content-type is used.