Skip to content

man update for docker run with host volumes#16287

Merged
moxiegirl merged 1 commit intomoby:masterfrom
mikebrow:16055-man-update-for-docker-run-with-host-volumes
Oct 9, 2015
Merged

man update for docker run with host volumes#16287
moxiegirl merged 1 commit intomoby:masterfrom
mikebrow:16055-man-update-for-docker-run-with-host-volumes

Conversation

@mikebrow
Copy link
Copy Markdown
Contributor

@mikebrow mikebrow commented Sep 14, 2015

man page sync up for docker run -v. Fixes issue #16055

Signed-off-by: Mike Brown [email protected]

SvenDowideit
SvenDowideit reviewed Sep 15, 2015
View reviewed changes
man/docker-run.1.md Outdated
Copy link
Copy Markdown
Contributor

@SvenDowideit SvenDowideit Sep 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on the Docker host?

Copy link
Copy Markdown
Contributor Author

@mikebrow mikebrow Sep 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and good idea but it would be the only place where "Docker host" is mentioned in the document. Host without the adjective is used throughout. So I think it's better to keep with host in this case.

@SvenDowideit
Copy link
Copy Markdown
Contributor

SvenDowideit commented Sep 15, 2015

LGTM, though this makes me realize - does that mean that the z/Z SELinux options are not written about?

@mikebrow
Copy link
Copy Markdown
Contributor Author

mikebrow commented Sep 15, 2015

@SvenDowideit

Ok, there's some text in the man page about it but not up on the web page docker ref. So yes we need to fix that.

Will update it and amend.

@mikebrow
Copy link
Copy Markdown
Contributor Author

mikebrow commented Sep 17, 2015

deprecate bind path auto-create #16349

@mikebrow
man update for docker run with host volumes
2b6b9a8 
Signed-off-by: Mike Brown <[email protected]>

cleaning up docker run -v documentation for man and web reference guide

Signed-off-by: Mike Brown <[email protected]>
@mikebrow mikebrow force-pushed the 16055-man-update-for-docker-run-with-host-volumes branch from cb4343b to 2b6b9a8 Compare September 17, 2015 17:16
@mikebrow
Copy link
Copy Markdown
Contributor Author

mikebrow commented Sep 17, 2015

@SvenDowideit
Ok, I've clean up and synced up the web page and man documentation for docker run -v bind mount option. Note: I also added text (and a link to the deprecation page on the two web pages) indicating that the auto creation of the folder has been deprecated.

@calavera calavera mentioned this pull request Sep 18, 2015
Merged
@thaJeztah thaJeztah mentioned this pull request Sep 24, 2015
Closed
@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Sep 27, 2015

LGTM! thanks again Mike

ping @SvenDowideit PTAL

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Oct 9, 2015

ping @moxiegirl PTAL

@moxiegirl
Copy link
Copy Markdown
Contributor

moxiegirl commented Oct 9, 2015

Very nicely done...I could object to the be forms "has been" but that'd be tragic at this point. LGTM Thank you @mikebrow

moxiegirl pushed a commit that referenced this pull request Oct 9, 2015
Merge pull request #16287 from mikebrow/16055-man-update-for-docker-r…
26ee5fe 
…un-with-host-volumes

man update for docker run with host volumes
@moxiegirl moxiegirl merged commit 26ee5fe into moby:master Oct 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status/3-docs-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mikebrow @SvenDowideit @thaJeztah @moxiegirl @GordonTheTurtle