Prevent DNS server conflicts in CreateBridgeIface#1577
Conversation
|
@mrallen1 You should run |
|
I'd really like to fix this problem. If you have suggestions for the implementation, I'd be happy to rework my PR. Thanks. |
|
Ping @creack @vieux @crosbymichael |
|
This looks useful and I don't see any obvious problems. Any risks of false positives that you're aware of? |
|
We should really merge this. I apologize @mrallen1 for the delay. We are slowly but surely catching up on our backlog. /cc @vieux @crosbymichael. @mrallen1 want to give a shot at rebasing? We didn't change the network code much, so it should be easy. Thanks |
|
Sure. |
|
OK, rebase is finally finished. Switched the code to use the StripComments function and pull the nameserver IP from a regular expression which is a nice improvement over the original code. All tests pass. Please review @crosbymichael @shykes @vieux Thank you. |
|
LGTM, ping @crosbymichael @creack |
|
@mrallen1 could you squash your PR? |
|
Sure. I will do it tonight after work. |
Retrieve /etc/resolv.conf data (if available)
Add checkNameserverOverlaps and call it to
make sure there are no conflicts
Add utils.GetNameserversAsCIDR and tests
Read /etc/resolv.conf and pull out nameservers,
formatting them as a CIDR block ("1.2.3.4/32")
|
Commits squashed - ping @creack |
|
LGTM |
Prevent DNS server conflicts in CreateBridgeIface
5 participants
Fixes #1502