Fix "docker ps" with no containers regression#14919
Merged
calavera merged 1 commit intomoby:masterfrom Jul 23, 2015
Merged
Conversation
The header row was not being printed when "docker ps" was invoked without containers thanks to the new format support, and we instead received a single blank line. Signed-off-by: Andrew "Tianon" Page <[email protected]>
Contributor
There was a problem hiding this comment.
just curious, why does "table {{.Names}" result in one column but "table {{.ID}}" result in two?
edit: s/ID/Names/
Member
Author
There was a problem hiding this comment.
ID results in two words, not two columns -- I went with single column outputs here so that we wouldn't have to deal with potentially inconsistent TabWriter output (since it'll make nice spacing so the table is visually "pretty").
Contributor
|
LGTM |
Contributor
|
thanks for catching this and fixing and the test! LGTM |
Contributor
|
LGTM, thank you! |
calavera
added a commit
that referenced
this pull request
Jul 23, 2015
Fix "docker ps" with no containers regression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header row was not being printed when "docker ps" was invoked without containers thanks to the new format support, and we instead received a single blank line.
https://github.com/docker/docker/pull/14699/files#r35364230