lint for volume/*#14818
Conversation
|
LGTM |
|
Ping @cpuguy83 for review. |
There was a problem hiding this comment.
VolumeDriver in this context is explicitly for facilitating communications with plugins, and that is all.
There was a problem hiding this comment.
Looking at volumes and plugins for different reasons and I think I understand this a bit more. How is:
VolumeDriver defines the available functions that volume plugins must implement.
|
Some comments, these could probably even be improved. |
MHBauer
force-pushed
the
volume-lint
branch
2 times, most recently
from
9ca923e to
3ad1fee
Compare
MHBauer
force-pushed
the
volume-lint
branch
2 times, most recently
from
f3a8f3b to
9df12aa
Compare
There was a problem hiding this comment.
this should be volume/drivers
There was a problem hiding this comment.
I'm still learning go, so this is confusing to me. The directory path is volume/drivers, but the actual package name is volumedrivers which leads me to think it should be volume/volumedrivers. I realize it's the directory, not the actual name. Thanks.
- comments on exported values - constant string replaced by constant reference - unexport implementation details of VolumeDriver 'local' - add fixed packages to linter list Signed-off-by: Morgan Bauer <[email protected]>
7 participants
I am not familiar enough with volumes to understand totally what is going on in detail.
I need more expert eyes to make sure these are factual sentences.
for #14756