Windows: Factoring out unused fields#14694
Merged
jessfraz merged 1 commit intomoby:masterfrom Jul 28, 2015
Merged
Conversation
lowenna
force-pushed
the
10662-apparmorprofile
branch
from
9d3f4f5 to
58cdbf2
Compare
Contributor
|
It looks good at first glance. I don't know if |
Contributor
There was a problem hiding this comment.
please, don't leave an empty line here.
Member
Author
|
I was trying to be concise :) But next push will update it to createContainerPlatformSpecificSettings |
lowenna
force-pushed
the
10662-apparmorprofile
branch
4 times, most recently
from
b422111 to
0ee8496
Compare
Member
Author
|
Rebase from hell completed :) |
lowenna
force-pushed
the
10662-apparmorprofile
branch
2 times, most recently
from
076c7d3 to
cafc755
Compare
Contributor
|
oh, gosh. I'm very sorry. Changes LGTM. |
Contributor
|
:( needs rebasse |
Contributor
|
ping me after :) |
Signed-off-by: John Howard <[email protected]>
lowenna
force-pushed
the
10662-apparmorprofile
branch
from
cafc755 to
47c56e4
Compare
Member
Author
|
Rebased. Waiting for CI to complete. |
Contributor
|
ok only seems to be failing on stupid urandom, LGTM, merging |
jessfraz
pushed a commit
that referenced
this pull request
Jul 28, 2015
Windows: Factoring out unused fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@swernli
This PR is part of the proposal described in docker/docker issue 10662 to port the docker daemon to Windows. This PR addresses a lot of "TODO Windows" by refactoring many platform specific fields which were still common across all platforms into the right place. This includes
-- daemon\config: CorsHeaders; EnableCors
-- daemon\container: ResolvConfPath; HostnamePath; HostsPath; UpdateDns; MountPoints; Volumes; VolumesRW
-- daemon\inspect ContainerJSONBase
-- reworking of daemon\create due to above
-- reworking of daemon\volume due to above (there is more to do here, but I'm trying to limit the size of the PR)