Windows: hostconfig on start#14691
Merged
runcom merged 1 commit intomoby:masterfrom Jul 20, 2015
Merged
Conversation
Signed-off-by: John Howard <[email protected]>
Member
|
I'd prefer to just remove this for new API versions. |
Member
|
Also assuming we keep this, can't we just have |
Member
Author
|
@cpuguy83 - I'm not sure what the policy is for deprecation? I'm just trying to make sure it isn't a problem on Windows ;) |
Member
|
@jhowardmsft doh! of course... |
Member
Author
|
daemon.setHostConfig is called during create (the right place) as well as start. So I don't believe it can be a no-op on Windows. |
Member
|
This LGTM, but I'll probably open an issue about deprecating hostconfig on start for API versions > 1.19 |
Member
|
LGMT, creating issue about deprecating hostConfig on start as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard [email protected]
@swernli
This PR is part of the proposal described in docker/docker issue 10662 to port the docker daemon to Windows. This addresses a backwards compatibility issue which doesn't affect Windows, hence the Windows daemon errors out. (Specifically if a hostConfig is passed to start.)