Skip to content

Assume that if VAGRANT_DEFAULT_PROVIDER is set we shouldn't install vbox tools#1449

Merged
mzdaniel merged 1 commit intomoby:masterfrom
spkane:honor-ENV-VAGRANT_DEFAULT_PROVIDER
Sep 4, 2013
Merged

Assume that if VAGRANT_DEFAULT_PROVIDER is set we shouldn't install vbox tools#1449
mzdaniel merged 1 commit intomoby:masterfrom
spkane:honor-ENV-VAGRANT_DEFAULT_PROVIDER

Conversation

@spkane
Copy link
Copy Markdown

@spkane spkane commented Aug 7, 2013

In Vagrant, you can set VAGRANT_DEFAULT_PROVIDER in the shell to be your default provider (i.e. "vmware_fusion"). Assume that if this is set we should not install the vbox tools.

It would be ideal to improve this logic, so that we install the tools required for the provider in question (or have multiple prepared boxes), but this works for the moment.

@creack
Copy link
Copy Markdown
Contributor

creack commented Aug 7, 2013

/cc @mzdaniel

@ghost ghost assigned mzdaniel Aug 7, 2013
@spkane
Copy link
Copy Markdown
Author

spkane commented Aug 13, 2013

@mzdaniel Any chance that we can get this pulled in? The current Vagrantfile always loads the vbox tools for people who change their provider via this shell environment. Thanks.

@mzdaniel
Copy link
Copy Markdown
Contributor

Hi @spkane. You are raising a great point here: there are too many ways to express what provider should be used in Vagrant. I kept thinking on this and to be fair, I am not convinced we even need the vbox guest additions anymore. What do you think?

@spkane
Copy link
Copy Markdown
Author

spkane commented Aug 13, 2013

@mzdaniel I agree that the vbox additions are likely not required at all. I have been using the docker box in vmware_fusion without the VMware Tools, and it has been working fine for what I need.

@mzdaniel
Copy link
Copy Markdown
Contributor

@jimmycuadra has a nice implementation of this PR 1578.
@spkane: Do you need anything special in vmware_fusion for config.vm.share_folder to work?

@spkane
Copy link
Copy Markdown
Author

spkane commented Aug 26, 2013

@mzdaniel I'm not sure exactly what you are asking. VMware Tools needs to be installed in a box for full vagrant functionality (which includes shared folders), but many things work fine without it.

@mzdaniel
Copy link
Copy Markdown
Contributor

@spkane: The point is that for some developer users sharing folders with the VM is important, although it's easier to state it, that making sure it works in all different environments. That said, the point of the main Vagrant file is to run docker as easy as possible in as many environments as possible.
Would you mind slightly changing the focus of this PR and remove vbox tools from ./Vagrantfile?
If others want to have them included for development, we can look to add them at ./hack/Vagrantfile

@mzdaniel mzdaniel mentioned this pull request Aug 26, 2013
@mzdaniel
Copy link
Copy Markdown
Contributor

mzdaniel commented Sep 4, 2013

@spkane: Your PR is merged

mzdaniel added a commit that referenced this pull request Sep 4, 2013
Assume that if VAGRANT_DEFAULT_PROVIDER is set we shouldn't install vbox tools
@mzdaniel mzdaniel merged commit a0a5170 into moby:master Sep 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants