Assume that if VAGRANT_DEFAULT_PROVIDER is set we shouldn't install vbox tools#1449
Conversation
|
/cc @mzdaniel |
|
@mzdaniel Any chance that we can get this pulled in? The current Vagrantfile always loads the vbox tools for people who change their provider via this shell environment. Thanks. |
|
Hi @spkane. You are raising a great point here: there are too many ways to express what provider should be used in Vagrant. I kept thinking on this and to be fair, I am not convinced we even need the vbox guest additions anymore. What do you think? |
|
@mzdaniel I agree that the vbox additions are likely not required at all. I have been using the docker box in vmware_fusion without the VMware Tools, and it has been working fine for what I need. |
|
@jimmycuadra has a nice implementation of this PR 1578. |
|
@mzdaniel I'm not sure exactly what you are asking. VMware Tools needs to be installed in a box for full vagrant functionality (which includes shared folders), but many things work fine without it. |
|
@spkane: The point is that for some developer users sharing folders with the VM is important, although it's easier to state it, that making sure it works in all different environments. That said, the point of the main Vagrant file is to run docker as easy as possible in as many environments as possible. |
|
@spkane: Your PR is merged |
Assume that if VAGRANT_DEFAULT_PROVIDER is set we shouldn't install vbox tools
In Vagrant, you can set VAGRANT_DEFAULT_PROVIDER in the shell to be your default provider (i.e. "vmware_fusion"). Assume that if this is set we should not install the vbox tools.
It would be ideal to improve this logic, so that we install the tools required for the provider in question (or have multiple prepared boxes), but this works for the moment.