daemon: lower allocations#14268
Conversation
|
@unclejack Could you describe how it helps save memory? Also #12899 definitely has origins in never-removed execConfig structs. |
|
@LK4D4 execConfig structs are moste likely a small part of this. This saves memory by avoiding the allocation of io.Copy buffers. This saves about 96 KB per exec. |
|
Makes sense to write own |
|
@LK4D4 Fair enough, I'll add it to pools. |
There was a problem hiding this comment.
I know this is unrelated to the PR, but could we add a check for this error here.
|
@LK4D4 Sorry to disagree with you here, but we should avoid having a specialized version of |
|
@stevvooe but our function will be just wrapper around. Helper method not helping here, because we have hardcoded pools in pkg/pools. |
bbb7504 to
838e441
Compare
|
@unclejack Looks like some tests are broken. |
|
@LK4D4 I've reproduced the failure and I'm working on fixing it right away. |
Signed-off-by: Cristian Staretu <[email protected]>
838e441 to
c1477db
Compare
|
@LK4D4 The tests seem to be OK now. There's more work to be done for this, but this is good enough for one PR. |
|
LGTM |
1 similar comment
|
LGTM |
This PR helps improve things with #12899. I'm not going to say this fully fixes it for now as there are other changes to be made.