Merged
Conversation
Signed-off-by: Madhu Venugopal <[email protected]>
Contributor
|
LGTM |
daemon/container_linux.go
Outdated
Contributor
There was a problem hiding this comment.
What the point of this variable? This is basically mode.IsDefault()
Contributor
Author
There was a problem hiding this comment.
Not required. it was added for readability.
But have changed it (added comments instead).
Contributor
|
I think most interesting changes here in docs. |
experimental/networking.md
Outdated
Contributor
|
LGTM (networking.md to be sorted globally at a later date.) |
This commit makes use of the CNM model supported by LibNetwork and provides an ability to let a container to publish a specified service. Behind the scenes, if a service with the given name doesnt exist, it is automatically created on appropriate network and attach the container. Signed-off-by: Alessandro Boch <[email protected]> Signed-off-by: Madhu Venugopal <[email protected]>
Signed-off-by: Dave Tucker <[email protected]> Signed-off-by: Madhu Venugopal <[email protected]>
Contributor
|
LGTM |
This was referenced Jul 7, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on various discussions and inputs, we have a simplified proposal to address the network UI
separate from services ui. This PR brings in the services ui & api provided by libnetwork and hooking it
to be part of docker.
All of these are defined under experimental tag in order to get user feedback before making it officially into the docker ui chain.