Minor doc edit to add clarity around the --volume path format#13776
Merged
moxiegirl merged 1 commit intomoby:masterfrom Jun 6, 2015
Merged
Minor doc edit to add clarity around the --volume path format#13776moxiegirl merged 1 commit intomoby:masterfrom
moxiegirl merged 1 commit intomoby:masterfrom
Conversation
Contributor
Author
Contributor
There was a problem hiding this comment.
Tics not quotes please. Sorry, I see this was let through before and you were just following a bad precedent.
Contributor
Author
There was a problem hiding this comment.
yep - just following someone else's lead :-) fixed.
Member
There was a problem hiding this comment.
Given that this approach (ie, a code-block describing the flag/option) is already used extensively in this document, I think this is fine (for consistency).
Also add a comment to the ValidatePath func so devs/reviewers know exactly what its looking for. Signed-off-by: Doug Davis <[email protected]>
Member
|
LGTM, thanks @duglin |
Contributor
|
LGTM |
moxiegirl
pushed a commit
that referenced
this pull request
Jun 6, 2015
Minor doc edit to add clarity around the --volume path format
Contributor
|
danke @duglin |
Member
|
Oh, i18n thanking! :) Dankjewel, @duglin |
Contributor
|
@jfrazelle cherry pick on this one please |
Contributor
|
cherry-pciked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also add a comment to the ValidatePath func so devs/reviewers
know exactly what its looking for.
Signed-off-by: Doug Davis [email protected]