Migrate data from old vfs paths to new local volumes path.#13728
Merged
crosbymichael merged 1 commit intomoby:masterfrom Jun 4, 2015
Merged
Migrate data from old vfs paths to new local volumes path.#13728crosbymichael merged 1 commit intomoby:masterfrom
crosbymichael merged 1 commit intomoby:masterfrom
Conversation
calavera
added
status/2-code-review
kind/bug
daemon/volumes.go
Outdated
Contributor
There was a problem hiding this comment.
Should this only happen if we are using the local driver?
Contributor
Author
There was a problem hiding this comment.
yeah, this is only called when there is a /var/lib/docker/vfs/dir/VOLUME_ID directory, which only happens using the local driver in versions < 1.7. After 1.7 all volumes are in /var/lib/docker/volumes.
calavera
force-pushed
the
copy_old_volume_content
branch
2 times, most recently
from
2c57941 to
5243357
Compare
daemon/volumes.go
Outdated
Contributor
There was a problem hiding this comment.
That's a tricky code path: if you fail to remove, you'll try rename backup back to volumeInfo, which is now taken (L313). Maybe that's the one error path where we should only log the error?
calavera
force-pushed
the
copy_old_volume_content
branch
from
5243357 to
c762739
Compare
Contributor
|
LGTM |
Signed-off-by: David Calavera <[email protected]>
calavera
force-pushed
the
copy_old_volume_content
branch
from
c762739 to
16a5590
Compare
Contributor
|
LGTM |
crosbymichael
added a commit
that referenced
this pull request
Jun 4, 2015
Migrate data from old vfs paths to new local volumes path.
Contributor
|
cherry-picked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bug upgrading from Docker 1.6 to Docker 1.7.
Before:
After:
Signed-off-by: David Calavera [email protected]