Merged
Conversation
calavera
force-pushed
the
plugin_json_spec
branch
2 times, most recently
from
6ba097d to
718ac7e
Compare
calavera
force-pushed
the
plugin_json_spec
branch
from
718ac7e to
d8d96e8
Compare
Contributor
|
I'm +1 on design, we're going to need something richer at some point. |
Contributor
|
Ping @cpuguy83 @diogomonica WDYT? |
Contributor
There was a problem hiding this comment.
Do we want to allow an override? Why?
Contributor
Author
There was a problem hiding this comment.
I'm okay with not allowing it.
3 tasks
5 tasks
calavera
force-pushed
the
plugin_json_spec
branch
from
d8d96e8 to
c50e682
Compare
Contributor
Author
|
I've rebased this PR to use the |
Contributor
|
LGTM |
calavera
force-pushed
the
plugin_json_spec
branch
from
c50e682 to
333ac3a
Compare
Allow full configuration of external plugins via a JSON document. Signed-off-by: David Calavera <[email protected]>
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow full configuration of external plugins via a JSON document.
Opening the possibility of out of the host plugins and TLS configurations.
Signed-off-by: David Calavera [email protected]