Skip to content

respect -H in bash completion#13195

Merged
tianon merged 1 commit intomoby:masterfrom
albers:completion-custom-host
May 21, 2015
Merged

respect -H in bash completion#13195
tianon merged 1 commit intomoby:masterfrom
albers:completion-custom-host

Conversation

@albers
Copy link
Copy Markdown
Member

@albers albers commented May 13, 2015

At present, bash completion ignores custom docker daemon settings specified with -H.
This is nasty if you work with swarm and get completions for the local docker instance.

This PR applies any global -H setting from the commandline to docker invocations needed for gathering completions.

Signed-off-by: Harald Albers <[email protected]>
@albers
Copy link
Copy Markdown
Member Author

albers commented May 13, 2015

@tianon @jfrazelle ping

@jessfraz
Copy link
Copy Markdown
Contributor

cool! LGTM :)

@jessfraz
Copy link
Copy Markdown
Contributor

ping @tianon hehe

@tianon
Copy link
Copy Markdown
Member

tianon commented May 21, 2015

NICE

LGTM

tianon added a commit that referenced this pull request May 21, 2015
@tianon tianon merged commit f74d9b8 into moby:master May 21, 2015
@albers albers deleted the completion-custom-host branch May 21, 2015 06:33
sdurrheimer added a commit to sdurrheimer/docker that referenced this pull request Jul 14, 2015
- Add fluentd logging driver to zsh completion moby#12876
- Add inspect --type flag to zsh completion moby#13187
- Respect -H option in zsh completion moby#13195
- Fix number of argument limit for pause and unpause in zsh completion

Signed-off-by: Steve Durrheimer <[email protected]>
calavera pushed a commit to calavera/docker that referenced this pull request Jul 25, 2015
- Add fluentd logging driver to zsh completion moby#12876
- Add inspect --type flag to zsh completion moby#13187
- Respect -H option in zsh completion moby#13195
- Fix number of argument limit for pause and unpause in zsh completion

Signed-off-by: Steve Durrheimer <[email protected]>
tiborvass pushed a commit to tiborvass/docker that referenced this pull request Jul 27, 2015
- Add fluentd logging driver to zsh completion moby#12876
- Add inspect --type flag to zsh completion moby#13187
- Respect -H option in zsh completion moby#13195
- Fix number of argument limit for pause and unpause in zsh completion

Signed-off-by: Steve Durrheimer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants