Windows: Volume path aware mkdirall#12718
Merged
estesp merged 1 commit intomoby:masterfrom May 4, 2015
Merged
Conversation
pkg/system/filesys_windows.go
Outdated
Contributor
There was a problem hiding this comment.
Aren't we better off using raw string literals for this kind of things?
Contributor
There was a problem hiding this comment.
Good point; I forgot to make that change. Updating to use literal.
pkg/system/filesys_windows.go
Outdated
Contributor
There was a problem hiding this comment.
godoc must start like // MkdirAll ...
Member
Author
There was a problem hiding this comment.
Sorry - don't understand what the problem is.... ;)
Contributor
swernli
force-pushed
the
10662-mkdirall
branch
3 times, most recently
from
a5a354d to
99be6d7
Compare
Signed-off-by: jhowardmsft <[email protected]>
Member
Author
|
Rebased |
Contributor
There was a problem hiding this comment.
you can put the regex in a private var to only compile it once.
Member
Author
|
2 - 0? Couldn't resist :) |
Contributor
|
cheaters :P LGTM |
Contributor
|
LGTM |
estesp
added a commit
that referenced
this pull request
May 4, 2015
Windows: Volume path aware mkdirall
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jhowardmsft [email protected]
@swernli
This PR is part of the proposal described in issue 10662 to port the docker daemon to Windows. It implements a volumepath aware version of mkdirall which is required for the Windows graph driver (for which the PR has not yet been submitted). Behaviour is unchanged on Linux.