Skip to content

Add tag option to syslog#12668

Closed
ibuildthecloud wants to merge 1 commit intomoby:masterfrom
ibuildthecloud:syslog-tag
Closed

Add tag option to syslog#12668
ibuildthecloud wants to merge 1 commit intomoby:masterfrom
ibuildthecloud:syslog-tag

Conversation

@ibuildthecloud
Copy link
Copy Markdown
Contributor

Note: This PR is based off of #12422. Both this and that PR need to be rebased

Currently the syslog tag is the container ID. This PR allows the user to specify any value for the tag. More context in #12391

@ibukanov
Copy link
Copy Markdown

It is more useful to allow to specify not a tag but a pattern or template that can refer to container id and name so both can present in logs.

@tlunter
Copy link
Copy Markdown
Contributor

tlunter commented May 6, 2015

Would really love an option like this!

@ibuildthecloud
Copy link
Copy Markdown
Contributor Author

@LK4D4 any chance you can review this. The design is based on your suggestions.

@thaJeztah
Copy link
Copy Markdown
Member

@ibuildthecloud #12422 was merged, can you rebase this PR?

@ibuildthecloud
Copy link
Copy Markdown
Contributor Author

Will do, thanks

Signed-off-by: Darren Shepherd <[email protected]>
@terbooter
Copy link
Copy Markdown

Very useful feature!

@runcom
Copy link
Copy Markdown
Member

runcom commented May 21, 2015

@ibuildthecloud could you please rebase this due to #12422 is now merged? also this will be kinda related to #13362

@thaJeztah
Copy link
Copy Markdown
Member

@runcom and (at least, I suggested), related to #12876, because that PR also has a way to specify the "tag" for logging. Would be nice to have a consistent UX for defining the tag among the various log-drivers

@runcom
Copy link
Copy Markdown
Member

runcom commented May 21, 2015

@thaJeztah thanks for pointing to that, will keep that in mind. Now just wait @ibuildthecloud to rebase because many things changed here. And btw yes, would be cool to have something just for the tag option because other -log-opt are needed for other thinghies such as defining network hosts, ports etc etc per log driver

@thaJeztah
Copy link
Copy Markdown
Member

I still think it's good to define via --log-opt, just that if it's done that way, it would be nice if all drivers used the same convention (where possible). I don't think a dedicated flag should be added just for the 'tag'.

@LK4D4
Copy link
Copy Markdown
Contributor

LK4D4 commented Jun 2, 2015

@ibuildthecloud I'll carry this for you. Thanks for work! Sorry for all that bikeshedding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants