Add tag option to syslog#12668
Conversation
|
It is more useful to allow to specify not a tag but a pattern or template that can refer to container id and name so both can present in logs. |
|
Would really love an option like this! |
|
@LK4D4 any chance you can review this. The design is based on your suggestions. |
|
@ibuildthecloud #12422 was merged, can you rebase this PR? |
|
Will do, thanks |
Signed-off-by: Darren Shepherd <[email protected]>
903ecf2 to
6a74b6f
Compare
|
Very useful feature! |
|
@ibuildthecloud could you please rebase this due to #12422 is now merged? also this will be kinda related to #13362 |
|
@thaJeztah thanks for pointing to that, will keep that in mind. Now just wait @ibuildthecloud to rebase because many things changed here. And btw yes, would be cool to have something just for the tag option because other -log-opt are needed for other thinghies such as defining network hosts, ports etc etc per log driver |
|
I still think it's good to define via |
|
@ibuildthecloud I'll carry this for you. Thanks for work! Sorry for all that bikeshedding. |
Note: This PR is based off of #12422. Both this and that PR need to be rebased
Currently the syslog tag is the container ID. This PR allows the user to specify any value for the tag. More context in #12391