Conversation
api/server/server.go
Outdated
There was a problem hiding this comment.
Is this trick really necessary here? I think it will be enough just return error. At least it'll preserve old behavior.
graph/export.go
Outdated
There was a problem hiding this comment.
I'll totally remove this line since it's not a job anymore, or maybe write another message
Signed-off-by: Simei He <[email protected]> Signed-off-by: He Simei <[email protected]>
dalanlan
force-pushed
the
remove_job_from_image_export
branch
from
5122621 to
30557fc
Compare
|
thanks @dalanlan |
|
looks ok to me apart from that engine needed in exportImage |
There was a problem hiding this comment.
Why we just don't return error here? I'm pretty sure that you're not returning JSONError from ImageExport.
There was a problem hiding this comment.
Ah, I got it. But we're not doing Used trick then?
There was a problem hiding this comment.
I think it is superweird. You should write json-error directly to w if error encountered after Flushed.
There was a problem hiding this comment.
It's the NEW legacy of postImagesCreate.
i thought u guys were not pleasant with Flushed or Used stuff and somehow i was not able to make binary locally due to network problem so i just corrected it in your way:(
I would write a pr to correct postImagesCreate then since it is also weird when you type docker pull scratch or sth.
7 participants
part of #12151
remove job from image_export
Signed-off-by: Simei He [email protected]