Do we need a test involving container rename oldname newname to verify that the logs properly follow a container rename?

@ibuildthecloud I'm -1 on names by default as @phemmer , and I have same concerns as @thaJeztah . I think that there is more usecases about IDs, then about Names. But I'm +1 on log-opts for syslog where tag can be specified.
Also I like format proposed by @phemmer: docker/ID.
Facility ok for me.

I'll like @phemmer format, but still want container names. I think we can agree that there are use cases for both. We will make it configurable, I'll personally put in the PR for that, but 1.6 I still think container name is more friendly.

I update the PR to be "docker/NAME"

Okay, my thoughts about id-name war:

• I don't really see big difference between docker run --name=cron and docker run --name=cron --log-opts="tag=cron"
• I want tags to be simple strings and don't want to introduce tag=string: tag=id tag=name
• names can be changed with rename - and handling this will require significant changes to driver

ping @crosbymichael @calavera @tiborvass @jfrazelle @icecrime

ok so my stance on this is id as default and we can have --log-opt added in 1.7 to make configurable
also as @LK4D4 said setting as name will cause problems when you rename a container

and to quote @shykes from another chat "container IDs only please"

Okay, I'm taking my toys and going home.

I updated the PR to do container ID. So the PR just changes the facility and then the final format will be "docker/ID" looking like:

Apr 15 00:16:05 inotmac docker/1234567890AB[30851]: hi

@thaJeztah now that the format is ID, i don't think a rename test is really needed.

sorry :(

@ibuildthecloud not as part of this PR, no. But I think it will be needed for the 1.7 (1.6.1?) update that supports --log-opts

I realise the outcome here is not what you hoped for (I tried, within reason), but given the short time before the release, I think it's reasonable. "Go go gadget log-opts" for the next release!

LGTM

ok cherry-picked into release bump