move syslog-tag to syslog.New function#12329
move syslog-tag to syslog.New function#12329x1022as wants to merge 1 commit intomoby:masterfrom x1022as:syslog-tag
Conversation
Signed-off-by: Deng Guangxing <[email protected]>
|
ping @ibuildthecloud |
|
This will change log-format, so we should decide it right now or never. |
|
What is standard for syslog message format? |
|
Having the "before and after this patch" look of the log would be super helpful. ✨ ⚡ ✨ |
|
Before: After |
|
I'm not sure why it looks like this. Maybe because of |
|
The standard for syslog format is here https://tools.ietf.org/html/rfc5424#section-6.5 This is the before and after before: after |
|
@wlan0 WDYT overall about this change? |
|
@LK4D4 It makes parsing easier. 👍 |
|
@wlan0 Cool, thank you very much. |
|
cool added and moved to code review :) |
There was a problem hiding this comment.
Could you replace this with logrus.Error(err)?
|
I opened #12340 with this commit but removing the println |
|
Fwiw, I think this makes the log harder to read. Before it was clearly process_name[pid] like most syslog. Now it's process_name: id[pid]. |
|
@LK4D4 Sorry I wasn't around earlier, I think you should revert this. |
9 participants
move syslog-tag to syslog.New()
With tremendous log, this may cost less.
<tag>makes it easy to parse the log.Signed-off-by: Deng Guangxing [email protected]