Remove job from container stats#12312
Merged
cpuguy83 merged 1 commit intomoby:masterfrom Apr 13, 2015
Merged
Conversation
Contributor
|
@runcom Can you split your changes to two commits, pls? |
Member
Author
|
Sure! |
Member
Author
There was a problem hiding this comment.
no, if err is nil it means api call was ok, i'm looking for failure here
Contributor
There was a problem hiding this comment.
Oops~, i misunderstand that, ignore my noise
Signed-off-by: Antonio Murdaca <[email protected]>
runcom
force-pushed
the
remove-job-container-stats
branch
2 times, most recently
from
9846255 to
65a0563
Compare
Member
There was a problem hiding this comment.
Creating a flusher here but daemon.ContainerStats only accepts an io.Writer?
Contributor
There was a problem hiding this comment.
it should be io.Writer. Flush called automatically on each write.
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
cpuguy83
added a commit
that referenced
this pull request
Apr 13, 2015
Remove job from container stats
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Antonio Murdaca [email protected]