Merged
Conversation
cpuguy83
force-pushed
the
remove_commands_integration
branch
from
ae10208 to
0ceeb6b
Compare
Contributor
|
@cpuguy83 Doesn't compile. |
Member
Author
|
Bad rebase. One sec. |
cpuguy83
force-pushed
the
remove_commands_integration
branch
from
0ceeb6b to
1d70af3
Compare
Member
Author
|
Fixed |
Contributor
|
@cpuguy83 Test failed. |
cpuguy83
force-pushed
the
remove_commands_integration
branch
from
1d70af3 to
9488585
Compare
Member
Author
|
Race condition in test, fixed. |
Member
Author
|
|
cpuguy83
force-pushed
the
remove_commands_integration
branch
from
9488585 to
6145a08
Compare
cpuguy83
force-pushed
the
remove_commands_integration
branch
from
6145a08 to
f38c2f9
Compare
cpuguy83
force-pushed
the
remove_commands_integration
branch
from
f38c2f9 to
56c291b
Compare
cpuguy83
force-pushed
the
remove_commands_integration
branch
from
56c291b to
c58c625
Compare
Contributor
|
@cpuguy83 Still an issue it seems: |
Member
Author
|
sigh not sure how it even got that error. |
cpuguy83
force-pushed
the
remove_commands_integration
branch
from
c58c625 to
29d9f0b
Compare
Signed-off-by: Brian Goff <[email protected]>
Signed-off-by: Brian Goff <[email protected]>
Signed-off-by: Brian Goff <[email protected]>
Signed-off-by: Brian Goff <[email protected]>
This test is already being skipped, and is also fully tested by `TestRunContainerWithRmFlagExitCodeNotEqualToZero` Signed-off-by: Brian Goff <[email protected]>
Everything else was gone from this file except these utils which are being used in other files and can't yet be removed. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
remove_commands_integration
branch
from
29d9f0b to
7d738e0
Compare
Member
Author
|
All good now. |
integration/utils.go
Outdated
Contributor
There was a problem hiding this comment.
Whoa, seems like this functions is not used. And we can remove awful GetPtyMaster!!!!
Signed-off-by: Brian Goff <[email protected]>
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves all tests from
integration/commands_test.gointo an integration-cli test.