Merged
Conversation
runcom
force-pushed
the
remove-job-commit
branch
from
63b91c7 to
58e725c
Compare
Contributor
|
@runcom I think it is first engine-removal which adds more lines, than remove :) |
Member
Author
|
@LK4D4 you're right but I had to adapt everything from that env.* |
Member
Author
|
I'm trying to figure out why some tests failed btw |
daemon/commit.go
Outdated
Contributor
There was a problem hiding this comment.
I think you can use SetenvJson(c.Changes)
runcom
force-pushed
the
remove-job-commit
branch
from
58e725c to
a2c95e2
Compare
runcom
force-pushed
the
remove-job-commit
branch
from
a2c95e2 to
f3222a2
Compare
Member
Author
|
@LK4D4 integration-cli tests are ok now, basically I've removed the first dependency from commit on engine/job but yet, daemon commit still has a dependency on engine/job with build_config job from builder (tough one, discussed on IRC) |
Signed-off-by: Antonio Murdaca <[email protected]>
runcom
force-pushed
the
remove-job-commit
branch
from
f3222a2 to
c8529fd
Compare
Member
Author
|
Removed tests from integration/server_test.go because of #12282 |
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @LK4D4 My attempt to remove job from commit but then it still need job from builder, hope this is ok to continue with.
Signed-off-by: Antonio Murdaca [email protected]