Seems like changing behavior and not consistent with other stuff.
Maybe just forceRemove := r.Form.Get("force") != ""
and remove vars?

mmm why changing behaviour? jobs arguments were parsed to bool. Ok to remove vars btw

I wanted to directly pass bools to ContainerRm instead of strings to be converted (as job was doing if i'm right)

I don't see where they was parsed at all. only r.Form.Get

@LK4D4 this basically do the same as https://github.com/docker/docker/blob/master/engine/env.go#L57
but that one use env to get the key etc etc...I don't like this toBool here... should I move it elsewhere? (where)

Better to be in server. This doing basically the same that was jobs.

I know this function is Env.GetBool, but god it's horrible... :-(

It's fine to keep it as it was before, but with all the recent PR to remove engine.Job, hasn't anyone already implemented that one somewhere else?

Nope, so probably somewhere something broken :)

mmm haven't reallly looked at that. But I firstly thought about moving this to pkg/stringutils but it's not so generic to convert a string to a bool that way so I skipped that...then as lk4d4 said I moved it here so if someone other needs it (and she will because many bool flags are passed to daemon that way) she may reuse it.. I think this is the new implementation of Env.GetBool that server should use to convert string to bool maintaining backward compatibility... to my knowledge of course...

what about decoding the Form into a struct instead wouldn't that solve this?

EDIT: ugh url params sorry
Also http://www.gorillatoolkit.org/pkg/schema

Nice!

Problem that we need to preserve weird old behavior.

This might be a good candidate for a struct with so many bool args.

wdyt?

I'm ok with it, I've followed your discussion on irc about 5+ args then struct so I thought it would make sense not to do a struct.

Yeah, the issue is you end up calling this function like this daemon.ContainerRm("foo", true, true, false), and it's difficult to tell what the bools are really for without digging.

@cpuguy83 alright, I'll make a struct for this then