Check container is running before trying to kill it and log kill event#12085
Closed
runcom wants to merge 1 commit intomoby:masterfrom
Closed
Check container is running before trying to kill it and log kill event#12085runcom wants to merge 1 commit intomoby:masterfrom
runcom wants to merge 1 commit intomoby:masterfrom
Conversation
runcom
force-pushed
the
12083-check-container-running-kill-before-event
branch
6 times, most recently
from
7b4f9e7 to
db320b4
Compare
runcom
changed the title
runcom
force-pushed
the
12083-check-container-running-kill-before-event
branch
2 times, most recently
from
5e93c7d to
ce716ff
Compare
Signed-off-by: Antonio Murdaca <[email protected]>
runcom
force-pushed
the
12083-check-container-running-kill-before-event
branch
from
ce716ff to
e403f68
Compare
Contributor
|
Event issue was fixed by @duglin IIRC. |
Member
Author
|
yes it was meant for future version maybe..it that doesn't apply you can close this i think |
Contributor
|
@runcom You can close it yourself :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #12083
I'm opening this if the linked issue is ok, otherwise ignore (and sorry, close) this!
Also, I've modified
TestNetworkNatin integration-cli because with this I discovered that at the end of the test, a kill command was run against the first container but the container was just stopped (received message withncand exited) so now it would fail. Turns out that kill command wasn't needed there. (If I am right, but I highly doubt :))There are also two other test failing because of this,
TestPostContainersAttachandTestPostContainersAttachStderrunderintegration/, because they both try to kill an already stopped container. I've just commented the kill command but waiting feedbacks on what to do here.Signed-off-by: Antonio Murdaca [email protected]